Remove hard-coded file directory path from database.
jhuckabee - December 2, 2008 - 22:52
| Project: | CSS Injector |
| Version: | 6.x-1.3 |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Description
CSS Injector is currently storing the file name including the site's files directory path in the database for a given rule. I'm working on a project where we do a lot of copying of various sites for testing and development purposes where the files directory path is never the same. Every time we copy a site we have to either go update the database with the correct path, or manually reload the styles in the admin interface.
I'm submitting a patch that removes the file_path field from the database all together. Please consider merging these changes into the project.
| Attachment | Size |
|---|---|
| remove_sites_files_path.patch | 4.12 KB |
#1
Previous patch had an issue with saving new rules. Attaching a new patch.
#2
I have yet to try the patch, but will. It is a good idea as stated.
#3
The patch works for me. I second the idea of integrating it into the module.
#4
I ran into this when migrating over a site. I'll test this with the upgrade path as well. Pushing to critical because it breaks sites during migration.
#5
The patch shown in #1 works perfectly for me. This functionality is very much needed for anyone who ever moves a site from a development server to a production server (and changes the file directory path in the process).
Can we get this committed to the module ASAP?
Cheers,
Ben