Upgrade to 6.x
avivalma - December 3, 2008 - 20:50
| Project: | Content Blocker |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | avivalma |
| Status: | needs work |
Description
Here is an upgraded module. This version support FeedAPI instead of leech. (leech was abandoned)
| Attachment | Size |
|---|---|
| contentblocker.tgz | 12.06 KB |
#1
I just tested this and it works great! i also tested the feedAPI implementation and it works great! There are still some issues tho, I'll try to add more details to my review later, but this really works well!
+1
patchak
#2
I reworked the overview page and introduced the admin_visible property inside inc files to hide unneeded overview items.
#3
Very nice! definately +1 on this...
Patchak
#4
Thanks for contributing this update!
However, the upgrade was done on the 5.x version of the module. It needs to be done on HEAD, which has significant changes from the 5.x version.
Could you repeat the upgrade using the HEAD version?
Also, it would be easier to review if we had a straight update, and then separate issues for any changes being introduced.
Thanks!
#5
I ran the module through Deadwood, fixed up a couple of obvious errors, and applied the result to HEAD. This provides most of the needed updating, but needs testing and fixing up.
#6
avivalma: are up up for providing a patch that with updates I missed, including an include file for Feed API?
#7
I'm ready to work on it to provide a final 6.x version. Expect it in 5-10 days.