Bulk operations operates on all nodes in nodes table when select all nodes in view is chosen
jmcclelland - December 3, 2008 - 23:05
| Project: | Views Bulk Operations (VBO) |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | kratib |
| Status: | active |
Jump to:
Description
Bulk operations works fine when selecting one or two nodes or all nodes on a page, however, when selecting all nodes in a view, it tries to operate on all nodes in the nodes table, rather than limiting to just the ones in the view.
Specifically:
* Using views filter, limited results to 27 nodes
* Selected the all checkbox, then click Select All 27 nodes in view
* Chose the Change Workflow state of post to new state
* Clicked execute
* Chose new state
* Was given confirmation about changing 10 nodes (listed by title) plus 17 more
* Then, page timed out. When I reloaded I got a list of drupal messages about operations on dozens and dozens of nodes that were not selected.
#1
You're right! I will work on this right now.
#2
Fixed in the latest 5.x-1.x-dev. Please try it and let me know. You'll need to wait for Drupal to refresh the dev release though. Thanks for this report!
#3
Automatically closed -- issue fixed for two weeks with no activity.
#4
Thanks for the fix! I just tested against 5.x.-1.2 and it works like a charm.
#5
A similar bug still seems to exist in the 6.x version.
I want to delete all 'biblio' nodes (1000 nodes), so
* I select the appropriate filter in VBO,
* click the all checkbox for selecting all nodes on the pager
* click the button "select all 1000 rows in this view"
* click execute
* ... and on the next page, the confirmation page does not only list 1000 nodes, but ALL the nodes of the Drupal site. Proceeding indeed deletes all the nodes on the Drupal site, unselectively...
#6
A similar bug still seems to exist in the 6.x version.
I want to delete all 'biblio' nodes (1000 nodes), so
* I select the appropriate filter in VBO,
* click the all checkbox for selecting all nodes on the pager
* click the button "select all 1000 rows in this view"
* click execute
* ... and on the next page, the confirmation page does not only list 1000 nodes, but ALL the nodes of the Drupal site. Proceeding indeed deletes all the nodes on the Drupal site, unselectively...
#7
Acknowledged. It's a tough one too :-)
#8
Fixed in latest 6.x-1.x-dev (which should be available 12 hours from now). Please verify and let me know!
#9
I verify that this is now fixed.
Thanks!
#10
marked #384254: Delete operation not honoring selected filters selects ALL NODES! as a duplicate. i can also confirm that this is fixed in the -dev release.
#11
By the way, to everyone who got bit by that nasty bug: I apologize for not making a new VBO release as soon as I found it. This is a critical piece of functionality that can really mess up a site. Sorry for wasting your time and your data.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.
#13
Sorry to reopen this again, but you can reproduce this bug also when you are using a faceted view and VBO.
To reproduce:
1) Create a view with some operations (best to test is of course the delete action)
2) Create a faceted view, select the default view you created in 1 and add a block where you can select on content types.
3) Create 2 content types (page & story by default) and generate some content (devel generate!)
4) Select one content type, push select all and then the 'select all rows in this view' - you need paging of course ..
5) The confirm form will show more nodes than actually needed
The argument created by faceted, in this case something like 'content_type:page' seems to be ignored'
I'll be looking into this some more this week, maybe we should also create a config option on the bulk operations plugin to hide the 'select all rows in this view' button.
Not sure if this is faceteds fault or vbo, reporting back later this week.
#14
@swentel, please open a new issue for this since it seems to be specific to faceted views. You can close this one when you're done.
#15
@kratib, ok, created a seperate issue at #519692: Select all rows fails when using faceted views
#16
Same problem still exists in current dev (rel. Aug 4).
Unfortunately, I don't know how to reproduce it! But let me describe what I did:
I've been using the demo page /admin/content/node2 just fine in batch mode in FFox for a few hours today. Then I wanted to start another batch, in a different browser (IE8), as the same user. I selected another content type I need to delete, applied, then selected deletion, clicked button to select all 59k nodes, and executed the task. At the verification summary I saw the process was going to delete all 153k pages on the website!
I cancelled this, and I cancelled the other batch running in FFox as well. Cleared all caches on Drupal using Devel, cleared browser caches.
But now when I try to delete any content type this way, even the one that did work earlier, the select all button still shows the right number, but after submit the summary screen indicates it wants to apply it on all pages on the website.
Tried in IE, Chrome, FFox. Restarted Apache. Always the same problem. Cannot get out of this mode.
P.S. Cleared all APC cache. Disabled VBO module, tried to uninstall it but it has no uninstall feature, then re-enabled the module. Edited the demo view /admin/content/node2 and saved it again. Ran cron. Cleared all caches again. ... All the same, I am still locked in the mode where all website pages are selected!