The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.This code in uc_cart.js breaks the checkout form page (testing in firefox) because the $('form#uc-cart-checkout-review-form input#edit-submit') object does not exist.
This code appears to not apply to the checkout form but to the review form?
After deleting this code, the checkout works normally.
$('form#uc-cart-checkout-review-form input#edit-submit').click(function() {
$(this).clone().insertAfter(this).attr('disabled', true).after(' ').end().hide();
$('#uc-cart-checkout-review-form #edit-back').attr('disabled', true);
});
Secondly, in I.E. on the checkout form, I am getting the js error 'getEelementById' is not an object. However I have not yet been able to figure out where this comes from. I upgraded drupal and jquery too so it might not be an ubercart issue. Because of the eval code in jquery it is very difficult to troubleshoot. Still looking into that.
thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | ie_checkout_fix_d6.patch | 980 bytes | Island Usurper |
| #6 | ie_checkout_fix_d5.patch | 645 bytes | Island Usurper |
| #2 | throbber.1.x.patch | 2.04 KB | cha0s |
| #2 | throbber.2.x.patch | 2.32 KB | cha0s |
Comments
Comment #1
bob.hinrichs commentedAfter testing, I found the IE error is related. It also went away when the code was removed (and had to clear the cache!)
Comment #2
cha0s commentedHey... those jQuery selectors are horrible, who could have written that code?!
So anyways, I ID'd the submit and back buttons in the checkout review form and in all the modules that hook into that form and modify the submit button to point at other sites. Hopefully that is enough to appease IE. Here are the patches for both versions:
Comment #3
cha0s commentedComment #4
Island Usurper commentedI don't know. I can't seem to find a way to keep IE from allowing me to checkout. If you upgraded jQuery, make sure you get the jquery_update module, which helps keep Drupal working smoothly.
The only weirdness that I noticed was that the shipping quotes won't update until you click away from the address panes. If this first click is on the "Review order" button, it doesn't submit, but the shipping quotes are refreshed. However, trying to submit the order again allows it to go through.
Hmm...I just realized that if you can't see the shipping pane on the same screen as the submit button, that's a really hard thing to notice. The only clue you get is the scrollbar suddenly getting bigger because there's less page to display.
Comment #5
Island Usurper commentedSo, this is now a usability bug, and a pretty big one, at that. I really wish that JavaScript had more standards than it does. Here's to hoping that supporting IE's quirks won't be as big a pain as it usually is.
Comment #6
Island Usurper commentedI suspected this was a bug I'd encountered before. Apparently, in Internet Explorer Land, onChange doesn't happen when you change the value of an element, but when you stop paying attention to it after you've changed. Like IE wants to make sure you really want to change it before it bothers doing something about it.
So the solution is to change from the change event to the click event.