Please find attached a patch to install minimal support for PostgreSQL. Not thoroughly tested as I only needed it to fix a bug (posting an issue for it after this one). Nonetheless, it'll mean I don't have to write the patch if I have to fix more bugs.

Comments

danielb’s picture

Hi Sammys, thanks for your interest and support of this module. I will try to get this patched in as soon as I can.

danielb’s picture

Status: Needs review » Fixed

I've patched it in for the new release, I can't test it because I don't have pgsql but I trust if there a problems it will be brought out in the issue queue.

sammys’s picture

Thanks for applying the patch. The most common problems people have are queries containing strings with double quotes (1) and type conversion assumptions (2).

  1. db_query('SELECT * FROM {blah} WHERE blahkey = "1"') should be db_query("SELECT * FROM {blah} WHERE blahkey = '1'")
  2. As you can see in the above, blahkey is a varchar() or text field. db_query('SELECT * FROM {blah} WHERE blahkey = 1') would give an error. Correct is db_query('SELECT * FROM {blah} WHERE blahkey = '1')

Hope this helps you check for the common errors.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.