Line 194:

  // Trust the browser...  ack!
  if (!$mime) {
    $mime = $file->filemime;
  }

Is there a specific reason why you're trusting the browser for file-type checking before the list of extensions?
I'm having an issue here, where m4a files (aac) aren't being correctly recognised as "audio/mp4", so I've added them to the list of known extension_mimes, and moved the browser-trust BELOW the mime checker.

CommentFileSizeAuthor
#4 mimedetect_342636.D5.patch6.46 KBdrewish
#3 mimedetect_342636.patch6.45 KBdrewish
#1 mimedetect_342636.patch5.44 KBdrewish

Comments

drewish’s picture

drewish commented
Title: Trust the browser? » Don't trust the browser and use file_get_mimetype()'s more complete database.
Version: 5.x-1.0 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new mimedetect_342636.patch5.44 KB

you're right it really isn't a good idea. i'm dropping it and using core's file_get_mimetype() function since it's got a more complete database of extension to mime mappings.

drewish’s picture

drewish commented
Status: Needs review » Fixed

found that mimedetect_mime() wasn't actually checking if the mimedetect_enable_file_binary variable was true before calling file. fixed that so i'm going to go ahead and commit this to HEAD and DRUPAL-5.

drewish’s picture

drewish commented
StatusFileSize
new mimedetect_342636.patch6.45 KB

forgot the patch.

drewish’s picture

drewish commented
StatusFileSize
new mimedetect_342636.D5.patch6.46 KB

here's what went into D5

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.