"Mark the selected comments as spam" not working

All bulk operations appear to be broken on that page. Reviewing now.

This was caused by some an anti-looping kludge. While I've not dove into the looping, I enhanced it so that we can perform multi-node operations (which were being detected as looping).

Fix committed to the 5.x and 6.x branches.

Hey, I just downloaded and installed the lasted development snapshot, and I don't believe this fixed the problem. Can somebody run through and test again?

Also, in v3.0 beta1, if I have comments in the approval queue that I want to mark as spam, clicking "mark the selected comments as spam" doesn't do anything. This is different from trying to mark published comments as spam. When I try to mark multiple published comments as spam, only the first one is marked.

Let me know if you need more details on anything. Awesome module otherwise!

(Sorry if I wasn't supposed to reopen the issue this way, I don't have a lot of experience with the bug tracking system)

Just to make sure: you're testing on Drupal 5.x?

I'm unable to duplicate -- and, I recommend upgrading to Drupal 6 as that's where our primary development efforts are focused. Closing issue as it works in my testing, feel free to re-open if you're still having a problem.

I also had this same issue. It seemed to be a combination of 1 the anti-looping kludge keeping from marking more than 10 comments as spam from the "published" queue and comments were completely unable to be marked as spam from the approval queue. I have provided a patch that excludes the call from the comment_admin_overview form.

Fix for loop for comment_admin_overview form

@@ -1661,7 +1661,7 @@ function spam_links($type, $id, $content
 function spam_mark_as_spam($type, $id, $extra = array()) {
   // TODO: Fix this loop
   static $loop = FALSE;
-  if ($loop) {
+  if ($loop && !$extra['comment_admin_overview']) {

Fix for comments not being able to be marked as spam from the approval queue.

@@ -197,7 +197,7 @@ function comment_spamapi($op, $arg1 = NU
     case 'unpublish':
       // Only update comments that exist and need to be unpublished.
       // When 'unpublishing' comments, we actually mark them as spam.
-      $nid = db_result(db_query('SELECT nid FROM {comments} WHERE cid = %d AND status = %d', $arg1, COMMENT_PUBLISHED));
+      $nid = db_result(db_query('SELECT nid FROM {comments} WHERE cid = %d AND (status = %d || status = %d)', $arg1, COMMENT_PUBLISHED, COMMENT_NOT_PUBLISHED));

This is already fixed in the more recent 5.x-3.x-dev build. That is probably the one that should be used instead of the currently published beta1.

Hi there,

I'm reopening this thread because I'm getting this problem with spam 6.x-1.0.

- Activate spam and all filters
- Receive a bunch of spam
- Go to content/comment/approval
- Select any number of messages (1 or all)
- Select "Mark the selected comments as spam" in the operations list, then submit
- A green message appears: "The update has been performed."
- However, and this is unexpected, the selected messages remain in the approval queue, and the list admin/content/comment/list/spam is empty (No comments available.)
- There is nothing at all in admin/reports/dblog

Cheers,

Albert.

Hi again, I'm confirming that the above scenario happens even on a brand new Drupal 6.19 installation with only the spam module enabled (no filters).

Duplicate of #670764: Moderated comments marked as spam not in spam queue.