Currently Display Plugins can participate in the validation of the complete View. This functionality should be useful for other plugins as well as handlers.

Attached a patch which allows handlers to participate in the validation of the View. The patch includes few minor remotely related comments enhancements as well.

Btw, it looks like *only* display plugins are called out during view validation. Don't you think all plugins should be able to validate the view? I didn't want to touch this part so the patch doesn't get out of hand.

CommentFileSizeAuthor
#3 views_handlers_validate4.patch6.41 KBAmrMostafa
#2 views_handlers_validate3.patch7.02 KBAmrMostafa
#1 views_handlers_validate2.patch6.41 KBAmrMostafa
views_handlers_validate.patch5.64 KBAmrMostafa

Comments

AmrMostafa’s picture

AmrMostafa commented
StatusFileSize
new views_handlers_validate2.patch6.41 KB

... and here we have a better patch which doesn't try to validate() handlers which are inherited from the default display.

Thanks for the tip Earl!

AmrMostafa’s picture

AmrMostafa commented
StatusFileSize
new views_handlers_validate3.patch7.02 KB

Tiny fix in the help. (6 plugin types instead of 5).

AmrMostafa’s picture

AmrMostafa commented
StatusFileSize
new views_handlers_validate4.patch6.41 KB

My bad. Patch wasn't generated with the correct relative directory.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed! Thanks a lot for this, this is valuable!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.