Download & Extend

Move taxonomy_get_tree internal $depth parameter to the end

Project:Drupal core
Version:7.x-dev
Component:taxonomy.module
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

If $depth is for "Internal use only" then why is it in the middle of the parameter list? If we're not supposed to use it, we shouldn't have to care about its default value either.

AttachmentSizeStatusTest resultOperations
taxonomy_get_tree-depth.patch2.7 KBIdlePassed: 7524 passes, 0 fails, 0 exceptionsView details

Comments

#1

Good idea. I can confirm this patch also updates all occurences of taxonomy_get_tree() in core where needed.

#2

Status:needs review» reviewed & tested by the community

Much better.

#3

Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#4

Status:fixed» needs work

This probably deserves a mention in http://drupal.org/update/modules

#5

Will do.

//Edit: done!

#6

Status:needs work» fixed

Marking as fixed then :)

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here