Title entities breaking
AlexisWilke - December 5, 2008 - 20:38
| Project: | Aggregation |
| Version: | 6.x-1.3 |
| Component: | User interface |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Jump to:
Description
If you get a newsfeed that includes something like & or ' in the title (and most certainly any other entity) you transform them to "text". It is indeed safer but looks rather bad.
You can see an example in the first article on this image:
http://drupal.org/files/issues/Google-URL.png
My take on that looks like this at this time, but it would be neat to have that in the module at some point:
<?php
print str_replace(array('&#39;', '&amp;'), array("'", '&'), $feed_title);
?>in the aggregator-item.tpl.php file (which I made a copy in my own theme for the purpose.)
Thank you.
Alexis Wilke
#1
I tested it, but the entities inside the feed seem to appear correctly in the title on the site.
Could you please provide me with the URL to the feed, and if not possible, save the feed locally and attach it to this issue?
If there is an issue here I'm hoping to fix it on the coming release scheduled real soon. So your prompt reply is greatly appreciated.
#2
Hi mistknight,
The feed on my site is here:
http://www.turnwatcher.com/aggregator/sources/6
Note that it won't look wrong on my site as I fixed it. (that problem and the super very long URL too)
But you should be able to get the feed URL on your site and check for these problems there. I look at the page and it looks like there are some ' characters in there as usual.
Thank you.
Alexis Wilke
#3
Another note:
I think that the real fix should be in the check_plain() or whatever function it is that should test for valid entities and not transform them. I do not know of any entity that's so bad that hackers could make use of them anyway.
Thank you.
Alexis