From #321295: Errors when other modules incorrectly implement link_alter I did a search for modules that incorrectly implement link_alter. forumthread is one of the offenders. The docs for hook_link_alter say that the function should be passed $links, then $node (a reversal from D5). Your implementation currently passes the parameters in reverse:

      $links = module_invoke_all('link', 'comment', $comment, 1);
      foreach (module_implements('link_alter') as $module) {
        $function = $module .'_link_alter';
        $function($node, $links);
      }

Should be

      $links = module_invoke_all('link', 'comment', $comment, 1);
      drupal_alter('link', $links, $node);
CommentFileSizeAuthor
#1 forumthread-link-alter-D6.patch880 bytesdave reid

Comments

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new880 bytes

Patch included for your review.

jbrauer’s picture

Assigned: Unassigned » jbrauer

Thanks Dave. I'll get that addressed!

dave reid’s picture

Thanks very much JBrauer!

dave reid’s picture

Any progress on this?

jbrauer’s picture

Status: Needs review » Reviewed & tested by the community

Thanks Dave looks good... it's in -dev

jbrauer’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Committed long ago now.