Nodereference path token should use drupal_get_path_alias() instead of url()

Using url() instead of drupal_get_path_alias() for the nodereference path token causes problems when used in conjunction with the subdomain module. The subdomain module provides subdomain pathauto support by replacing a prefix (defaults to "~") with an appropriate subdomain. Using url() to get the path of a referenced node if that node is set to use a subdomain will return the wrong path for the referenced node.

To replicate this issue:

1. Install cck, nodereference, pathauto, and subdomain
2. Create a new content type of "Test"
3. Create a new content type of "Subtest", and add a nodereference to "Test"
4. Set pathauto for node type "Test" as "[subdomain]/[title-raw]"
5. Set pathauto for node type "Subtest" as "[field_test-path]/[title-raw]"
6. Create a new node of type "Test" titled "test1"
7. Create a new node of type "Subtest" titled "subtest1"

The node "test1" will be given the url alias of "~test1" and will be rewritten to "http://test.test.com/test1" (given the base url of test.com).
The expected rewrite behavior for "subtest1" would be the url alias of "~test1/subtest1" and would be rewritten to "http://test.test.com/test1/subtest1". Instead, "subtest1" is given the url alias of "http:/test.test.com/test1/subtest1" and will be rewritten to "test.com/http%3A/test.test.com/test1/subtest1". Obviously this isn't the desired result.

This can be easily solved by using drupal_get_path_alias() instead of url(). If you look at pathauto.module, it uses drupal_get_path_alias() to set the termalias. I would argue that the nodereference path token should be renamed to "alias" to match pathauto, but the supplied patch only changes url() to drupal_get_path_alias(). It also makes a related change for the userreference path token.

Quite the long explanation for a two line patch, I know, but I hopefully the explanation was enlightening :).

Thanks,
Jon Duell