A current bug against Acidfree "Add Child Page" links? wanted to know why "Add Child Page" links and other book links were showing up on Acidfree node pages. It turns out that this is cause because both Acidfree and Book have the parent field set. In book's book_link(), it only checks to see if parent is set, not if it is actually a book node type. Here is a patch that remedies this and fixes the problem.

The problem is visible in HEAD and 4.6. Please review the patch and apply it. It has already been tested by some Acidfree users saying that it fixes the problem. It allows the links to show up on book pages, but not on Acidfree pages.

I am also marking Bug # 33180 as a duplicate of this bug.

CommentFileSizeAuthor
book.module.links.patch418 bytesvhmauery

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Closed (won't fix)

Any node type can be placed into the book and then it needs the book links. I guess acidfree also sets the "parent" property and thus the links show. I suggest renaming the property in acidfree.