Download & Extend

Notifications do not have sender information in them

Project:Organic groups
Version:6.x-2.x-dev
Component:og_notifications
Category:bug report
Priority:critical
Assigned:Unassigned
Status:active

Issue Summary

In the messaging framework you need to provide a 'sender_account'

$from = check_plain($message['sender_account']->name) . ' <'.$message['sender_account']->mail.'>';

but og on like 604 does from.

'from' => $user,

When a user replies to a message it comes back to the site admin address.

Comments

#1

Well making that change in the code does not work for us either.
on line 125 of og_notifications we h ave

        notifications_lite_send($uid, $args['subject'], $args['body'])

We never pass the from param.

#2

subscribing

#3

We've noticed this discrepancy too. The sender address is different for plain notifications and og_notifications. This had the frustrating side effect of our SMTP server discarding some messages as spam, and others not. Fortunately we had access to the logs as there was not even an error message in the Drupal logs.

(IMHO notifications is not currently ready for use within og. There are far too many issues. This, and others.)

#4

Version:6.x-1.0» 6.x-2.x-dev
Priority:critical» normal

Still relevant in 2.x?

#5

Priority:normal» critical

Yes, they still come from the site address rather then from the user who is taking the action.

Same with broadcast.

#6

Confirmed that broadcast, at least, is passing along the current user account as "sender" but this is not being passed along to the notification call.

#7

Component:og.module» og_notifications

#8

Is this only related to 6.x and not to 7.x?

#9

Maybe this is related to #1067198: sender_name should be used when preparing mail - where they were being sent as "anonymous" ?