Errorcheck in line 87 should have $settree['rsp']['err'] instead of $top_level_tree...

rfay - October 17, 2005 - 19:56
Project:Flickr Module
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

The check for error returned in line 87 of flickr.module is wrong, I believe.

It is currently:
    if (!empty($top_level_tree['rsp']['err']) || empty($settree))

but it should be
    if (!empty($settree['rsp']['err']) || empty($settree))

This causes an error instead of the expected response if the API key is invalid.

#1

rfay - November 28, 2007 - 05:11
Status:active» closed

This is ancient history and the current module is in great shape.

 
 

Drupal is a registered trademark of Dries Buytaert.