Yea - CSS 2.1 Complaint but not XHTML

mgifford - December 7, 2008 - 04:32
Project:Dreamy
Version:6.x-1.4
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:active
Description

This div seems to be already defined:

Do you validate the scripts before publishing them? Had any experience with WCAG validation - http://www.sidar.org/hera/index.php.en

Nice theme btw!

#1

bboyjay - December 17, 2008 - 03:33
Priority:normal» minor

I'll get to this when I have time.
Unless someone would like to write a patch, I can commit it.
Thanks

#2

mgifford - December 17, 2008 - 14:54

I haven't had time to submit a patch for this theme. I did test it against http://wave.webaim.org/ though and identified some minor issues that should be cleaned up too.

When the latest stable release validates it would be good to add that to the description page.

#3

peterx - February 25, 2009 - 05:35

The theme passes CSS 2.1, CSS 3, fixed, US 508, Wave, WCAG A, and XHTML 1.0 Strict tests on http://d-theme.com/dreamy. WCAG WAI tests show just one change is needed to reach an AAA rating. There is an empty link that breaks WAI AA rules.
<a class="feed-button" href="/rss.xml"></a>

#4

mgifford - February 25, 2009 - 20:31

There are issues if you have left & right sidebar blocks enabled.

Also, if you have sidebar blocks with not title http://wave.webaim.org/ still complains without this patch.

Thanks for making it better Jason. It's a good theme.

Mike

AttachmentSize
dreamy.patch 2.65 KB

#5

peterx - February 26, 2009 - 04:06

There are two h1s, not a good idea. Perhaps the following line could change.
<div id="header"><h1 class='site-name'><a href="/" title="Home">D theme for da Web site</a></h1></div>

To:
<div id="header"><a href="/" title="Home" class="site-name">D theme for da Web site</a></div>

or:
<div id="header site-name"><a href="/" title="Home">D theme for da Web site</a></div>

#6

mgifford - February 26, 2009 - 05:09

Agreed.

#7

peterx - February 26, 2009 - 07:46

While you are working on the patch, consider this change. The menu bar background did not run beyond the first line of the menu. When I shrink down the screen at http://d-theme.com/dreamy, the menu div does not expand vertically to cover the second and third line of the menu. I made a variety of changes and one worked.

In style.css, remove height from #menu. Then add the following dummy division to put invisible content after the menu so the menu div will extend to the end of the menu.
ul#navlist:after
    {
    content: ".";
    display: block;
    height: 0;
    visibility: hidden;
    clear: both;
    }

There are hundreds of thousands of pages online where people ask for help with this problem and are told it is IE only, despite many of the problem reporters using Firefox 2 or 3. I get the problem in the almost new Firefox 3.0.5. Most of the Drupal themes with horizontal menus have the same menu breakup. A nicely fixed working example would be good. A nicely fixed working example with an official recommended release would be best.

#8

peterx - February 26, 2009 - 09:43

Grab the enclosed image and add it to the theme. Change wrapper to:
#wrapper {
margin:0 auto;
width: 900px;
background: #f3f3f3 url(images/bg-header-right.jpg) repeat-x scroll 0 0;
font-size:1.20em;
}

See the effect at http://d-theme.com/dreamy. The theme is one step closer to being width independent. bg-header-right.jpg fills the top space without breaks. #f3f3f3 provides a continuous grey instead of the cheap substitute provided in the page background image.

The only bit left is the grass at the bottom. You could then make the width an administration setting.

AttachmentSize
bg-header-right.jpg 29.88 KB

#9

peterx - February 26, 2009 - 09:57

The grass is solved easily. Change the image in #footer from no-repeat to repeat-x.

#10

bboyjay - March 11, 2009 - 13:42

Cool. I'll look into these on the weekend.

 
 

Drupal is a registered trademark of Dries Buytaert.