Closed (fixed)
Project:
Delicious
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Reporter:
Created:
7 Dec 2008 at 07:00 UTC
Updated:
5 Feb 2009 at 23:30 UTC
Jump to comment: Most recent
The code in delicious_nodeapi() calls _delicious_tag_text() for both $node->body and $node->teaser. However, almost always only one of them is the right one to process. The other will be empty.
When this happens, _delicious_tag_text() unnecessarily loops on all the tags passing an empty $text variable to a preg_match().
Attached a patch which does an emptiness check in delicious_nodeapi() before processing.
| Comment | File | Size | Author |
|---|---|---|---|
| delicious_body_teaser_check.patch | 797 bytes | AmrMostafa |
Comments
Comment #1
Anonymous (not verified) commentedThankyou!
I'll get that committed to the development branch tomorrow.