I'M just about to translate the module into german and foung the following issues:

The string 'Deleted event(s):' should be split into a plural and a singular form for translatability.

It's the same with the string 'Attendee will bring a total of %guests guests.'

The string 'Are you sure you want to remove attendee ' cannot be correctly translated if it is followed by the attendees name (because in german the structure of the sentence is different: the attendees name needs to be inside of the string). So the string must be change into something like the existing string 'The attendee !name has been removed.'.

Also a construction like 'You may also !add attendees to this invite.' with a sepatate string for '!add' is not too good for translation: it is not sure how to translate !add in this case, in german there may be several translations depending on how constructing sentences. For translation purposes it is better to have simple constructions.

Could you also give me a hint what RSVP stands for (what the abbreviation exactly stands for)?

Comments

FrankT’s picture

FrankT commented

...there are also several string that could be split into singular and plural forms beginning with 'The following recipient(s) are invalid:'...

ulf1’s picture

ulf1 commented

I am not that familiar with how translations work in drupal.

1)
Plural/Singular: I believe it is fine if only the plural form is being used/translated. The plural form is always hardcoded so you could use the plural form in german as well:

'Deleted event(s)' => 'Geloeschte Einladungen'
'Attendee will bring a total of %guests guests.' => 'Die eingeladene Person kommt mit insgesamt %guests Gaesten'

2)
How would you setup the line to make it easier to work in other languages without changing the layout so that only a wors is linkable:

'#value' => t('You may also !add attendees to this invite.', array('!add' => l(t('add'), 'rsvp/email/'. $invite->hash .'/attendees')))

Thanks,
Ulf

FrankT’s picture

FrankT commented

My opinion in providing a singular/plural form is different: For users it is better (less disturbing) to match the text with the number of elements it refers to.

I can't answer your question 2) because I'm really not into programming.

Could you help me about in translating RSVP (what is it meant to be the abbreviation for)?

ulf1’s picture

ulf1 commented

I would not call it disturbing. But you are right that it would be perfect to have a singular and a plural form. But I believe for this small module this is only a minor detail.

I added a definition for RSVP to the projects handbook page:
#350019: Drupal 6 Integration
= http://drupal.org/node/350019

FrankT’s picture

FrankT commented
Status: Active » Closed (fixed)

In the meantime you changed 'RSVP' into 'invitation' in the strings, so it's easier to translate (and the question of the meaning of RSVP is obsolete, but good to know).

I guess to close the issue (and please keep the plurals in mind (occasionally)).