Content diff integration causing problems when other fields implement diff support
markus_petrux - December 7, 2008 - 18:05
| Project: | Content Construction Kit (CCK) |
| Version: | 6.x-2.x-dev |
| Component: | General |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
In file content.diff.inc there's a loop for all CCK fields in the nodes being compared and generates a row in $results even when field is not explicitly supported by this loop.
When a CCK field implements diff support, it generates its own results that are mixed by module_invoke_all used in diff module.
The attached patch fixes this. It generates results for diff module only for fields directly supported.
| Attachment | Size |
|---|---|
| content.diff.inc_.patch | 422 bytes |
#1
Please, see the following issue in Money's queue for an example where this bug arised:
#341365: Implement hook_diff() for improved revision management
#2
Fixed in 6.x-2.x (slightly different fix). Thanks !
I also removed the 'links module' code branches, they don't belong in CCK.
#3
Automatically closed -- issue fixed for two weeks with no activity.