Impromptu Dialog moves to top of page...

sethcohn - December 8, 2008 - 16:42
Project:CCK Field Privacy
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:obsidiandesign
Status:closed
Description

http://trentrichardson.com/Impromptu/index.php shows that Impromptu doesn't require you move to the top of the page to ask the dialog, but for some reason CCK Field Privacy does so. It's a bit confusing since if the profile item is lower on the page, you lose the focus of the user's page there.

Can you fix this so the dialog appears without changing page location?

#1

obsidiandesign - December 9, 2008 - 03:59
Version:5.x-1.x-dev» 6.x-1.x-dev
Assigned to:Anonymous» obsidiandesign
Status:active» needs review

The links that were used had an href="#", which was bouncing up to the top of the page. By removing the link, the JQuery Impromptu popup occurs directly over the current position on the page. I do need to work out the CSS so that the pointer still shows up over the lock, although that may be more of an issue for #220553: display of privacy values?, where the icons are being reworked anyway. Should apply as-is to 5.x, but marking for 6.x for the moment.

AttachmentSize
cck_field_privacy.module.overlay_popup.patch 2.3 KB

#2

obsidiandesign - December 21, 2008 - 03:47

Patch rerolled, tweaks a couple other issues, but does try to fix the cursor to a pointer when the user hovers over the padlock image. It works with fieldgroups, but isn't working with others. The style tag is being stripped. Can anyone provide some insight?

AttachmentSize
cck_field_privacy_double_padlock.patch 3.74 KB

#3

obsidiandesign - December 22, 2008 - 04:53
Status:needs review» fixed

A new method committed, thanks to ksenzee on #drupal for the new approach.

#4

System Message - January 5, 2009 - 05:00
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.