Hi Dave,

Thanks for the nice simple module. I was looking for a similar functionality in a module for a long time. I have created a Drupal 5 port (not a substantial change at all) for the instant search module. Can you please give me access to check in the code or commit to code to cvs? I am attaching the code.

Regards,
Sudeep Goyal
Ebizon Technologies
http://ebizontek.com

CommentFileSizeAuthor
instant_search5.zip7.84 KBsudeepg

Comments

davyvdb’s picture

davyvdb commented

Hi Sudeep,

Thanks for posting this but your code is incorrect. node_update_index() function different in Drupal 5. I also don't see why you need to use hook_menu for the settings for. This works in Drupal 6 too. And can you post clean code? Indentation, coding standards, ... http://drupal.org/coding-standards

davyvdb’s picture

davyvdb commented

Mmmh, looks like I'm using node_update_index incorrectly too. After fixing that the module is easily ported to Drupal 5. I'll take care of it.

davyvdb’s picture

davyvdb commented

The Drupal 6 version has been fixed. If possible, we can work on a Drupal 5 version now.

sudeepg’s picture

sudeepg commented

Ok.. i'll take up from here.. and would attach the reworked 5.x version. i'll get back to you in a day or 2.

Thanks,
Sudeep

davyvdb’s picture

davyvdb commented
Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Active » Fixed

Hi Sudeep,

I have just checked in a Drupal 5 version. You might wanna test this one.

sudeepg’s picture

sudeepg commented

Thanks a lot!! I will check that out.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.