Closed (fixed)
Project:
PNG Behave!
Version:
5.x-1.7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
9 Dec 2008 at 13:37 UTC
Updated:
29 Dec 2008 at 14:14 UTC
Jump to comment: Most recent file
Hi,
I get an error on page load whenever PNG Behave tries to do it's thing in IE6. I'm using version 5.x-1.7.
See here: http://screencast.com/t/q03KCD5DHI
Cheers,
Matthew
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | BlankImgPath-v2.patch | 1.67 KB | mrjeeves |
| #10 | BlankImgPath_v2.patch | 0 bytes | mrjeeves |
| #5 | BlankImgPath.patch | 1.67 KB | mrjeeves |
Comments
Comment #1
mrjeeves commentedyour browser seems to reporting a previous error, please post all errors occurring prior to the one you posted so I can backtrace the issue. Thank you for your time and testing.
Comment #2
mrjeeves commentedComment #3
mshepherd commentedHi,
The error I got was from a fresh install of PNG Behave & it the only error I noticed.
I'll start up XP in a minute and get ie6 running and check I didn't miss anything,
Thanks for your reply! I'll be back in touch
Matthew
Comment #4
mshepherd commentedHere goes:
Line: 11, Error: Expected '/'
The error is : Microsoft JScript runtime error: 'Drupal_base_path' is undefined'
I've also just noticed that your definition of where the module lives is not correct in my case. Although modules that are globally available are kept in the /sites/all directory, I generally store modules in /sites/sitename/modules. Is that an easy fix for you?
Thanks for the v5 branch of the module & I hope you can get it going for me without too much effort! Cheers
Matthew
Comment #5
mrjeeves commentedI had a feeling this may become an issue, try this patch and let me know.
Comment #6
mrjeeves commentedComment #7
mshepherd commentedHey mrjeeves. I'll try that in the morning. My colleague owes me some training on what to do with patch files! Now's as good a time as any to learn. Thanks for your time and I'll be back in touch soon,
Cheers
Comment #8
mrjeeves commentedfor future reference, you can view patch files in notepad or some similar reader and see exactly what changes the patch makes. in this case, it changes a line in iepngfix.htc and a line in pngbehave.module. thanks again for the testing, let me know if the changes work.
Comment #9
mshepherd commentedThanks for your notes about patches.
I've applied the patch and I still get an error, although slightly different:
The html contains the following code:
Which contains the correct path to the pngbehave module. Cheers for that.
I still got the same variable underfined error. However, I modified the htc file a little (seee below):
So, I hard coded the blankimage path. Good news, it worked & transparency has returned to my images - hopefully, that gives you something to go on. However, I still get an error on line 11: Expected ';'
Am I making sense?!
Thanks again for your help,
Matthew
Comment #10
mrjeeves commentedlooks like i forgot some quotes, try this one and see if it works better
This patch is written against the 5.x-1.7 version freshly installed
Comment #11
mshepherd commentedHi,
The patch file you uploaded has zero size.
Matthew
Comment #12
mrjeeves commentedsorry about that try it now
Comment #13
mrjeeves commentedThe patch has been committed to the 5.x-1.8 official release, marking as fixed.
Comment #14
mshepherd commentedApologies for not responding over the weekend. I've been away. I'll test later today and post back. But thanks for your time.
Best regards,
Matthew