Add a way to change the "[dot]" replacement text
jlkreiss - December 9, 2008 - 16:15
| Project: | SpamSpan filter |
| Version: | HEAD |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Wouldn't it be nice if one could change the "[dot]" replacement text in the filter configuration form, like for the "[at]" replacement text ? And maybe one day make these texts translation-aware ?
Because in other countries, people not always understand even simple english words as "at" or "dot"... We in France have "arobase" for "at" in email addresses, as an example. See the matter ?
Thanks a lot and have nice Drupal hacking...
#1
+ subscribing
And may you also add a option that allows to show a help which says "replace [at] by @ and [dot] by ." and hide this help with js. ... otherwise I don't think my grand parents will be able to send me a mail ;)
#2
+1, if only because I want to remove the spaces...
#3
Hi!
This patch adds a field to the admin page where the user can set the "[dot]" text just like the "[at]".
The patch is against 5.x-1.4
Hope it will be useful :)
Cheers, Gábor
www.zeneszapro.hu
#4
Thanks Gábor,
I'm working on getting this to work with drupal six, and it does when javascript is off, but when it's on, it doesn't replace the new "." replacement properly (because it's looking for "[dot]" instead).
here's the .module patch for 6.x, I'll see if I can fix the js problem.
#5
Ok, this patch also draws the spamspan_dot variable into Drupal.settings.spamspan.p (for period, or point), and uses that in the javascript file to create a regex string to to be replaced (globally).
I tried to re-compress the .js, but it didn't end up on a single line... anyway, it works now.
#6
Hi!
I have backported your patch to 5.x-1.4, but found that when the replacement string contains some regex characters [ ] { }, the js fails.
I found a code at http://simonwillison.net/2006/Jan/20/escape/ what escapes these strings properly. Maybe this would be a nice functionality in core as well (maybe it's already there, but i could not find it).
This patch is for 5.x-1.4
Cheers, Gábor
www.zeneszapro.hu
#7
I can't get that to work for 6, probably because I don't know much javascript, and I'm doing something wrong.
Also, you need to switch these lines around:
.replace(/\s+/g, '');.replace(dot_regex, '.')
Otherwise if the regex has a space in it, it won't match.