Fieldgroup padlocks require a weight change [#344897]

I wasn't seeing padlocks next to the checkbox for the fieldset group, but changing the weight on the module to a higher weight (running later) made them appear. I suggest this become part of the stock install, setting the module weight higher than zero. Before I did so, the fieldgroup wasn't available during the form alter, so there was nothing to match and alter.

I'm seeing doubled padlocks on the fieldgroup label, but at least I'm seeing ANY padlocks now. The checkbox for the fieldgroup is the first item in the admin, and should be more clearly 'pulled out' as a choice, but it does show up, and now the padlock(s) also shows.

Comment	File	Size	Author
#5	cck_field_privacy.install.344897_take_two.patch	1.16 KB	obsidiandesign
#1	cck_field_privacy.install_module_weight.patch	1.09 KB	obsidiandesign

Comments

Comment #1

obsidiandesign commented 21 December 2008 at 03:55

Status:

Active

» Needs review

Status	File	Size
new	cck_field_privacy.install_module_weight.patch	1.09 KB

@sethcohn, could you please give this a quick lookover? I want to make sure that hook_update_N is the appropriate place to change the module's weight before committing.

Bryan O'Shea
Obsidian Design

Comment #2

obsidiandesign commented 21 December 2008 at 03:55

Version:	5.x-1.x-dev	» 6.x-1.x-dev
Assigned:	Unassigned	» obsidiandesign

The patch, I think, will only work with 6.x since it's cck_field_privacy_6100. Updating the issue to match.

Comment #3

obsidiandesign commented 22 December 2008 at 05:42

Status:

Needs review

» Fixed

Committed to 5.x and 6.x CVS.

Comment #4

Anonymous (not verified) commented 24 December 2008 at 17:45

The patch didn't work for me but I changed updated SQL myself and made module weight 20 due to the fact that I found the cck fieldgroup module is 19!

Now I can see locks on the whole group but no more locks on fields already selected in the admin settings.

Hope that helps.

Comment #5

obsidiandesign commented 25 December 2008 at 05:23

Status	File	Size
new	cck_field_privacy.install.344897_take_two.patch	1.16 KB

@aliadnan - after you ran update.php, do you happen to remember what the weight was in the module table? I want to see if there's an error in what I did (maybe output into the watchdog, such as an SQL error?). I have rerolled the patch, with the weight based on CCK Fieldgroup, since on mine it was a weight of 9. Could you please retest & let me know the results (works good here).

Merry Christmas all!

Bryan O'Shea
Obsidian Design