Hi. Is there a reason why the pattern input fields are limited to only 128 characters? I'm using a complex mix of tokens that together are more than 128 characters long. I turned up maxlength to 256 in page_title.module, noticed no side effects so far.

Please make these fields accept longer values if possible. Thanks.

Comments

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Active » Closed (won't fix)

Technically speaking you can put as much as your want in the title... However according to W3C you should avoid titles longer than 80 characters. I believe in terms of SEO, 66 is the limit Google uses.

I'm marking this as "wont fix" as - if anything - 128 is excessive; 256 is far too long. If its working for you, great, but in the general situation (and especially in terms of SEO) a short punchy title is much better.

Anonymous’s picture

Anonymous (not verified) commented

Thanks for your reply.

I'm afraid there's a misunderstanding here. It's not my titles that are long but the pattern that I enter on the settings page:

[field_with_a_long_name-formatted] | [field_another_long_name-formatted] | [field_third_very_long_name-formatted] | [site-name]

And the actual output might looks like this:

Circle | Small | Red | Sitename

There is no direct connection between pattern length and the final title length. The pattern length can be extreme simply because the tokens refer to CCK fields that have long descriptive names.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Closed (won't fix) » Active

Ohhhh I see!

Hmm... I'll add this to a future release. Cheers.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Version: 6.x-2.x-dev » 5.x-2.x-dev
Status: Active » Patch (to be ported)

Committed to 6.x-2.x-dev. Will be in the official release.

Need to backport to 5.x at some point...

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Patch (to be ported) » Fixed

This is ported into both branches now. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Andrew Gorokhovets’s picture

Andrew Gorokhovets commented
Version: 5.x-2.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Active

This problem is still present.
Yes, it's global solved.
On the page admin/content/page_title - no error

But on the custom content type admin page (admin/content/types/[type]/edit)
This problem is still present.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Active » Fixed

Thanks - fixed in d6 and d7 dev branches. Well spotted.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chi’s picture

chi commented
Version: 6.x-2.x-dev » 7.x-2.5
Status: Closed (fixed) » Active

This problem is still present.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Active » Closed (duplicate)

This was a fix in the D5/6 branches - the D7 fix/bug was noticed in #1504416: Length limit for fields - marking as duplicate for house keeping.