Little bit optimizations -

function system_get_files_database(&$files, $type) {
  // Extract current files from database.
  $result = db_query("SELECT filename, name, type, status, throttle, schema_version FROM {system} WHERE type = '%s'", $type);
  while ($file = db_fetch_object($result)) {
    if (isset($files[$file->name]) && is_object($files[$file->name])) { //check if file on disk
      $file->old_filename = $file->filename;
      foreach ($file as $key => $value) {
-        if (!isset($files[$file->name]) || !isset($files[$file->name]->$key)) { // first condition always FALSE because of parent if
+        if (!isset($files[$file->name]->$key)) { 
          $files[$file->name]->$key = $value;
        }
      }
    }
  }
}

CommentFileSizeAuthor
system_files_D6.patch801 bytesandypost
system_files_D7.patch788 bytesandypost

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

Status: Needs work » Closed (duplicate)