Download & Extend
Issues

uninitialized value in _registry_check_code

Posted by miro_dietiker on December 10, 2008 at 6:34pm
Project:Drupal core
Version:7.x-dev
Component:base system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (works as designed)

Issue Summary

While reading
http://api.drupal.org/api/function/_registry_check_code/7
There's a potential of $cache_update_needed bein uninitialized when ($type == REGISTRY_WRITE_LOOKUP_CACHE)

This is only called in includes/common.inc in drupal_page_footer and $cache_update_needed makes sense only on that location if it was initially set to FALSE.

Login or register to post comments

Comments

#2

Posted by deekayen on May 12, 2009 at 4:36am
Status:active» needs review

...or maybe wrap it in empty()?

AttachmentSizeStatusTest resultOperations
345351_add_empty.patch680 bytesIdlePassed: 11226 passes, 0 fails, 0 exceptionsView details | Re-test

#3

Posted by Damien Tournoud on May 12, 2009 at 6:20am
Status:needs review» needs work

We haven't seen any warnings... does that mean that this optimisation is broken (ie. would $cache_update_needed always be true when entering _registry_check_code(REGISTRY_WRITE_LOOKUP_CACHE))?

#4

Posted by marcingy on December 7, 2012 at 3:59pm
Status:needs work» closed (works as designed)

I believe the report above is incorrect the value in question is a static and hence initialised to NULL. NULL can be testing in an if happily.