Posted by boombatower on December 11, 2008 at 8:50am
4 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | bug report |
| Priority: | critical |
| Assigned: | boombatower |
| Status: | closed (fixed) |
Issue Summary
The included test used to fail due to this issue. Discussed in IRC after mikey_p discovered.
Originally discover by the fact that http://drupalbin.com/4438 passed.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| simpletest_assertTitle.patch | 2.06 KB | Idle | Failed: 7619 passes, 2 fails, 0 exceptions | View details |
Comments
#1
Added assertNoTitle for consistency and to be able to write test.
#2
#3
davereid caught documentation issue.
#4
Makes complete sense to add assertNoTitle since assertTitle is one of the only assertions that doesn't include a negative. Also helpful to make sure that assertTitle works correctly like we discovered it does not. Docs need a tweak: "The string the title should NOT be."
#5
Too fast on trigger finger.
#6
Patch applies cleanly and fixes an uncaught error that will not be missed again now! RTBC
#7
chx noted that assertTrue|False would be more appropriate (been away too long)
#8
Still confirming RTBC. #7 is good to go.
#9
Committed to CVS HEAD. Thanks!
#10
Testing bot did not catch a failure now that assertTitle works properly.
#11
Really need to figure out why some slaves do not catch all the issues
#12
Revised patch that uses "Preview | Drupal" like the rest of core tests.
#13
Looks like its only slave #4 that is picking up the broken-ness. All others, no.
#14
Looks good.
#15
@11: We figured out the issue...so the testing bot misses should no longer occur. #338292: Correct regex for singular assertions
#16
Committed to CVS HEAD. Thanks.
#17
Automatically closed -- issue fixed for two weeks with no activity.