The included test used to fail due to this issue. Discussed in IRC after mikey_p discovered.

Originally discover by the fact that http://drupalbin.com/4438 passed.

CommentFileSizeAuthor
#12 head-broken-D7.patch817 bytesdave reid
#10 head-broken-D7.patch879 bytesdave reid
#7 simpletest_assertTitle.patch2.05 KBboombatower
#5 simpletest_assertTitle.patch2.06 KBboombatower
#3 simpletest_assertTitle.patch2.3 KBboombatower
simpletest_assertTitle.patch2.06 KBboombatower

Comments

boombatower’s picture

boombatower commented
Title: SimpleTest correct assertTitle logic » SimpleTest: correct assertTitle logic

Added assertNoTitle for consistency and to be able to write test.

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Category: task » bug
boombatower’s picture

boombatower commented
StatusFileSize
new simpletest_assertTitle.patch2.3 KB

davereid caught documentation issue.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: boombatower » Unassigned
Category: bug » task

Makes complete sense to add assertNoTitle since assertTitle is one of the only assertions that doesn't include a negative. Also helpful to make sure that assertTitle works correctly like we discovered it does not. Docs need a tweak: "The string the title should NOT be."

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Category: task » bug
StatusFileSize
new simpletest_assertTitle.patch2.06 KB

Too fast on trigger finger.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: boombatower » Unassigned
Category: bug » task
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and fixes an uncaught error that will not be missed again now! RTBC

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Category: task » bug
StatusFileSize
new simpletest_assertTitle.patch2.05 KB

chx noted that assertTrue|False would be more appropriate (been away too long)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Still confirming RTBC. #7 is good to go.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Critical
Status: Fixed » Needs review
StatusFileSize
new head-broken-D7.patch879 bytes

Testing bot did not catch a failure now that assertTitle works properly.

boombatower’s picture

boombatower commented

Really need to figure out why some slaves do not catch all the issues

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new head-broken-D7.patch817 bytes

Revised patch that uses "Preview | Drupal" like the rest of core tests.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Looks like its only slave #4 that is picking up the broken-ness. All others, no.

boombatower’s picture

boombatower commented
Status: Needs review » Reviewed & tested by the community

Looks good.

boombatower’s picture

boombatower commented

@11: We figured out the issue...so the testing bot misses should no longer occur. #338292: Correct regex for singular assertions

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.