Closed (works as designed)
Project:
Drupal.org site moderators
Component:
Other
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Dec 2008 at 14:17 UTC
Updated:
27 Jan 2009 at 15:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
vm commentedPlease link to the troublesome node.
Comment #2
kenorb commentedThis one and any of other.
I'm not able to remove, change of any my uploaded files.
Before it was working fine.
Comment #3
avpadernoI think VeryMisunderstood meant the link of the comment where you have problems on deleting, or editing your own attachments.
Comment #4
avpadernoComment #5
dave reidI think it's every comment upload now. I haven't been able to edit/delete them since the testing framework was enabled, since it would be bad to be changing patches during testing.
Comment #6
kenorb commentedSometimes I'm uploading some files which contain privacy information which I forgot to delete.
But whatever, my question is if it will be enabled as before or it will stay like that?
Or it will be consider to turn it on?
Comment #7
greg.harvey+1 ... we've noticed you can't edit your file lists any more. Is this deliberate?
Comment #8
avpadernoComment #9
kenorb commentedSometimes it can be confusing for some people in some cases, i.e.
case 1
you are uploading two patches, but you did made some small mistake in one, so you are uploading again, but you need to do that in the next post, so people crying that something is not working in the first patch, even you know that.
case 2
when you are working on some converting stuff (for 6.x) and the module is suspended so each hour you posting the new dumps or patches of patches, because you think it's the last one, and when somebody see 100 threads, they are confused which version they should use (you could did that in the cleaner way before).
Some live examples:
http://drupal.org/node/346264#comment-1220660
Comment #10
avpadernoSo far it is not clear if this is the wanted behavior, or it's really an issue.
I mean, no one of the Drupal webmasters said they must change that, so I guess this is the wanted behavior.
-- Kiam
Kiam la luno renkontas la sunon
Comment #11
heine commentedThis is by design (see also http://drupal.org/node/288592). Users should not be able to change followups as that would diminish the tracking functionality of the "issue tracker".
Comment #12
avpadernoThanks for your reply, Haine. Now who opened the issue should understand why nobody is doing anything about this.
I would add that even that report status has been set to by design.
Comment #13
greg.harveyHmmm, I'm not convinced this is smart... see #9 - both good examples. I'll create a feature request for a LinkedIn-style "you have 15 minutes to edit" feature, if this is the way forward...
Edit: done - http://drupal.org/node/360942
Comment #14
heine commentedI don't find the cases convincing.
Cas 1. I you modify an existing attached patch, confusion is even worse, as the patch in #N doesn't work for some, but does for others. Also, most people test and look at the last patches.
I don't understand case 2 at all.
The key here is tracking; modification of follow-ups only serves to confuse issues.
Comment #15
greg.harveyre: #1 ... fair point.
re: #2, I think he's saying it's better to be able to maintain a patch as an attachment on a single post, as a module maintainer. But you're right, I'm not convinced that has merit either with hindsight. If you want to do that, do it on your own server and post a link until you're ready to supply a finished patch to the community...?
I guess what *I'm* saying is it would be useful to be able to quickly tidy up any silly mistakes you notice within a few minutes of posting (which happens *a lot* and I don't subscribe to the Joel Spolsky "no edit makes people more careful" school of thought - it just doesn't work like that). I totally see the points made by yourself and others regarding avoiding confusion in the issue queue, but having to double-post because of a silly error is annoying, and one usually notices within a few minutes. See my feature request linked to in #13. For me, this is the best solution. It works very well for LinkedIn. =)
Comment #16
heine commentedAgreed. Our posts crossed.
Comment #17
heine commented@kenorb, please stop editing past followups.
I figure you added to #9:
I still don't see how that is confusing to someone with more than a pea for a brain. One can use the jumplist to go the most recent (ie last) attachment. Also, people routinely scroll to the bottom of an issue to find the latest news.
Consider the confusion for people in #346264: Missing argument 3 for _simplenews_template_theme_simplenews_newsletter_body in simplenews_template.module on line 370 when you would have been able to remove / update an attachment. Some would have downloaded/reviewed a different patch (pre and post-update respectively), making an effective discussion on the patch rather involved.
Comment #18
avpaderno@kernob: It's useless to continue to debate on this. It has been given a good reason to not permit a person to delete, or change the attachments put in a comment; who posts something that contains private informations should control what they attach to any public content.
The issue status has been then changed to by design; it means that if you don't give a really good reason to change how attachments are handled, they will not change that.
Comment #19
kenorb commentedOk, sorry.
Last important question related to this topic and security:
Is there any central place or someone who can delete some attachments for me on my request?
If I put some unneeded content (containing privacy information) which shouldn't be published without asking it on public?
Comment #20
avpadernoIf you attached a file to a comment that is publicly readable from anybody, then it's not a problem of security. It would be like talking of security for a container that is thought to be opened from anybody.
I think the answer to your question is no.
Comment #21
kenorb commentedOk, if there is no possibility of that, then I'm forced to use 3rd party websites to store my files or patches in case if I want to delete some of it (which can contain some server configurations details, passwords, SVN files, etc. uploaded by mistake)
Comment #22
kenorb commentedThank you Dave.