Development version, seems to be working really good. I've introduced region name match so that it automatically applies the same block in all the themes where region names are similar (which is "left sidebar" matches "left column" more than it matches "footer").

Anybody is welcome to give it a try. Attached

CommentFileSizeAuthor
#2 blockregion.minorfixes.patch4.88 KBdalad
blockregion-6.x-dev.tar_.gz8.43 KBdalad

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks!

I gave this a quick look over. Looks generally good. Some minro fixing up needed:

* $themeObj
should be $theme_object (coding standards).

* '#title' => 'Theme sharing options',
The title should be passed through t().

* if($do_basic)
blockregion_basic_sharing($blocks, $themes);

and various other control structures

Should be:

// Perform basic settings sharing
if ($do_basic) {
blockregion_basic_sharing($blocks, $themes);
}

(coding standards)

Please post a patch--much easier to review.

dalad’s picture

dalad commented
StatusFileSize
new blockregion.minorfixes.patch4.88 KB

Thanks again nedjo. I fixed those problems and further testing revealed still no issues. I think this module is ready to be released as 6.x
I'll upload to the CVS soon.

dalad’s picture

dalad commented
Status: Active » Closed (fixed)

6.x-1.1 available for download.