Hi, I added on to a previous issue (http://drupal.org/node/344298) because our problems are similar. However, I figured I should submit my own issue/support request.

If you click on a shadowbox link before the page fully loads, shadowbox does not work. In the case of a quicktime movie or image, it acts as a regular link and takes you to a new page with the image or movie on it. In the case of a flash/.flv movie, Firefox asks you if you want to open the file with an application or save it. Needless to say, this is undesirable.

Is there a way to get the $(document).ready(function(){ used by jquery to make the shadowbox links only work once the document is ready? Would this be implemented in the module, or should I be investigating putting this in my theme?

Comments

paulvantuyl’s picture

I have looked through everything with this module, and used the DOM inspector in Firebug. It looks like I was having a problem with the advertisement module when it used the javascript method for the display type. I have switched to Raw for the time being even though it doesn't work as well with caching enabled.

Also, I changed the 3rd line in shadowbox.js from $(window).load(function(){ to $(document).ready(function() {. I don't know if this is semantically correct, but its working for me so far (Please, if it isn't, school me. I like to learn). If a link is clicked before the page loads, Shadowbox behaves correctly and the page continues to load behind it.

psynaptic’s picture

I went with the window.load function due to reading about it on the shadowbox forum. If you have confirmed that document.ready is the better way to go for this module I would be happy to make that change.

psynaptic’s picture

Assigned: Unassigned » psynaptic
Status: Active » Fixed

Ok, after testing, this works well.

I have committed to DRUPAl-5--2 and DRUPAL-6--2. I think this change, even though very small, does justify a new release since it fixes a major bug.

Thanks for you help mrMaze:

http://drupal.org/cvs?commit=164506
http://drupal.org/cvs?commit=164507

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.