Found a couple of problems with ogactivity.module

1) If I am a group manager and I edit the group info, that gets recorded as me joining the group. Also, setting another existing group user as a group admin has a similar result. I'm attaching the patch to fix that below. Tested it under a bunch of circumstances to make sure joins are recorded only when the person is actually joining the group.

2) If a user requests to be added to a group and is denied, that is recorded as the user leaving the group. Unfortunately I do not see a way to correct that - OG does not differentiate between removing an existing user and removing a requesting user when throwing the delete event. It's really a pity - I may have to abandon this module in favor of a more custom solution :(

CommentFileSizeAuthor
ogactivity_update.patch862 bytesRoman S

Comments

jaydub’s picture

jaydub commented

#1 Yeah I think the best course of action is simply to ignore the 'user update' $op of hook_og().

#2 I don't see a way around this either. Still something is better than nothing...

Roman S’s picture

Roman S commented

If I remember correctly, always ignoring 'user update' did not work.. I think the problem was with moderated groups. The 'user update' op would fire when those users got approved, in which case you do want an activity record. My patch should be able to differentiate properly.

sirkitree’s picture

sirkitree commented
Status: Needs review » Closed (won't fix)

5.x unsupported please see 6.x-2