Hello

I am currently using your Upload Path module for a drupal project that I am doing. And as a part of the requirements I need to control the file names generated just like the path names are generated currently.

I was thinking of implementing this as patch in your current module since it will give me greater control on the the names of the files which are uploaded,

As of now there is only a cleaning file name option and a patch that enhances this functionality, but does not allow you to control the file name for a particular pattern.

So I wanted to do this as a patch in your modules since the feature is closely related to this module rather than a separate module.

What are you thoughts on this shall I go ahead with this?

Regards
Zyxware

CommentFileSizeAuthor
#4 uploadpath.admin_.inc_.patch3.17 KBzyxware
#4 uploadpath.module.patch1.68 KBzyxware
#4 README.txt168 byteszyxware
#4 changes.png52.36 KBzyxware

Comments

zyxware’s picture

zyxware commented

Link to the file names cleaning patch http://drupal.org/node/309853

davidwhthomas’s picture

davidwhthomas commented

Hi,

I would be interested in a patch that adds token support to the filename as well as the filepath.

At the moment, only the path uses tokens but if you could make a patch that uses tokens for 'clean filenames' I would consider committing it to the module.

DT

zyxware’s picture

zyxware commented
Assigned: Unassigned » zyxware

Sure DT, I get to work on it right away

zyxware’s picture

zyxware commented
Status: Active » Needs review
StatusFileSize
new changes.png52.36 KB
new README.txt168 bytes
new uploadpath.module.patch1.68 KB
new uploadpath.admin_.inc_.patch3.17 KB

Hello DT

Here is the quick patch that I made sometime back, I have done some quick testing and things seem to be going fine.

I have attached the following files as a part of this change.

2 Patch files
1 Readme
1 Screen shot of the changes in the Admin Section

There is a small conflict with Miscellaneous options "cleaning file names" since it also tries to rename files. Only one of them should be active at any given point of time.

Let me know of the progress.

Regards
Zyxware

davidwhthomas’s picture

davidwhthomas commented

Hi, thanks for the patch!

It looks good at a glance, I'll test it out more thoroughly and get back to you, looking good so far.

cheers,

DT