D6 Version

tony31 - December 12, 2008 - 13:41
Project:Top Searches
Version:5.x-1.1
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Is someone working on porting it to D6?

Thanks,
Tony

#1

z.stolar - December 12, 2008 - 15:06

I haven't started porting the module to D6 yet.
If you wish to submit the necessary patch, it might help speed things up.

#2

dropchew - December 16, 2008 - 05:22

+1 subscribe

#3

obsidiandesign - December 20, 2008 - 21:47
Status:active» needs review

Patch tested, made it for a project I'm working on for a client. Could use some additional testing before release.

Bryan O'Shea
Obsidian Design

AttachmentSize
top_searches_d6.patch 7.57 KB

#4

obsidiandesign - December 20, 2008 - 22:04

My patch in #3 has a single line of debug output still in it, sorry for that. I've rerolled the patch with that line removed.

Bryan O'Shea
Obsidian Design

AttachmentSize
top_searches_d6.patch 7.41 KB

#5

z.stolar - December 21, 2008 - 10:34

Thanks a lot Bryan!

I will test & apply the patch asap. Due to some winter health issues, this might take few days, but hopefully before before Christmas.

#6

z.stolar - December 23, 2008 - 20:31

@obsidiandesign: I am applying your patch now, and few things are unclear to me.
Currently I'm wondering why you chose to change the call
theme('top_searches_block', $top_searches);
to
theme_top_searches_block($top_searches);

Can you explain?

#7

z.stolar - December 23, 2008 - 20:51

Patch at #4 fails, but I'm working my way through it.

#8

obsidiandesign - December 23, 2008 - 22:41

@z.stolar - what CVS version are you patching against? I'll reroll to save you the efoort of manually patching.

Bryan

#9

z.stolar - December 23, 2008 - 23:16
Status:needs review» active

Releasing an RC. please test and approve.

#10

z.stolar - December 24, 2008 - 07:08

Bryan,

I didn't notice your last comment, but I was already in advanced stage anyway :)
If you take a look at the result, you'll see that I didn't implement all of your changes, but I did rely on them heavily, as well as added few other things.

Thanks a lot for your help though.
It was too late for me yesterday, so I didn't mention you in the release notes, but I'll do so in the official one.

#11

z.stolar - December 29, 2008 - 19:56
Status:active» fixed

RC3 is out. Looks pretty stable.

#12

System Message - January 12, 2009 - 20:00
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.