Is someone working on porting it to D6?

Thanks,
Tony

CommentFileSizeAuthor
#4 top_searches_d6.patch7.41 KBobsidiandesign
#3 top_searches_d6.patch7.57 KBobsidiandesign

Comments

z.stolar’s picture

z.stolar commented

I haven't started porting the module to D6 yet.
If you wish to submit the necessary patch, it might help speed things up.

dropchew’s picture

dropchew commented

+1 subscribe

obsidiandesign’s picture

obsidiandesign commented
Status: Active » Needs review
StatusFileSize
new top_searches_d6.patch7.57 KB

Patch tested, made it for a project I'm working on for a client. Could use some additional testing before release.

Bryan O'Shea
Obsidian Design

obsidiandesign’s picture

obsidiandesign commented
StatusFileSize
new top_searches_d6.patch7.41 KB

My patch in #3 has a single line of debug output still in it, sorry for that. I've rerolled the patch with that line removed.

Bryan O'Shea
Obsidian Design

z.stolar’s picture

z.stolar commented

Thanks a lot Bryan!

I will test & apply the patch asap. Due to some winter health issues, this might take few days, but hopefully before before Christmas.

z.stolar’s picture

z.stolar commented

@obsidiandesign: I am applying your patch now, and few things are unclear to me.
Currently I'm wondering why you chose to change the call
theme('top_searches_block', $top_searches);
to
theme_top_searches_block($top_searches);

Can you explain?

z.stolar’s picture

z.stolar commented

Patch at #4 fails, but I'm working my way through it.

obsidiandesign’s picture

obsidiandesign commented

@z.stolar - what CVS version are you patching against? I'll reroll to save you the efoort of manually patching.

Bryan

z.stolar’s picture

z.stolar commented
Status: Needs review » Active

Releasing an RC. please test and approve.

z.stolar’s picture

z.stolar commented

Bryan,

I didn't notice your last comment, but I was already in advanced stage anyway :)
If you take a look at the result, you'll see that I didn't implement all of your changes, but I did rely on them heavily, as well as added few other things.

Thanks a lot for your help though.
It was too late for me yesterday, so I didn't mention you in the release notes, but I'll do so in the official one.

z.stolar’s picture

z.stolar commented
Status: Active » Fixed

RC3 is out. Looks pretty stable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.