Can't save admin settings - "directory does not exist" [#34646]

On a windows system, the default temporary directory comes up as "c:\windows\temp" in admin/settings.

On loading the screen, I get the usual error message "The directory c:\windows\temp does not exist." - because I'm on Win2k, which uses "c:\winnt" instead. That's fine, except I can't actually make any changes to the page while that error message is still there: "The settings have not been saved because of the errors."

In other words, the screen is unusable if the path can't be found.

Comment	File	Size	Author
#1	file-temp-win.patch	712 bytes	asimmonds
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

asimmonds CreditAttribution: asimmonds commented 20 October 2005 at 10:02

Status:

Active

» Needs review

File	Size
file-temp-win.patch	712 bytes

Could we do something like this patch?

What I don't know is, what's the most common temp directory environment variable on a windows platform TEMP or TMP?

Comment #2

Thox CreditAttribution: Thox commented 20 October 2005 at 10:14

I admit that might solve the problem in my case, but is it the wrong way around to fix things? Regardless of the value of the field, it should never prevent you from changing it simply because it can't find a folder.

FYI, my Win2k system here has TMP and TEMP both set.

Comment #3

Geary CreditAttribution: Geary commented 30 October 2005 at 02:25

Status:

Needs review

» Needs work

The code should not contain any hard coded paths whatsoever. With the patch, the code still defaults to c:\windows\temp if the TEMP environment variable is not found. This is completely wrong. There is *no* standard default temp directory on Windows. If Drupal cannot find the correct temp directory, it should refuse to run, not take a wild guess like this.