Posted by jadestorm on December 13, 2008 at 7:05pm
Jump to:
| Project: | Daily Twitter |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | jadestorm |
| Status: | active |
Issue Summary
While I don't intend, at least yet, to make dailytwitter -completely- customizable, it might be nice to at least have some options depending on your preferences. Looking at what LoudTwitter offers might be a good start.
Comments
#1
I've been running a homegrown script that does a limited subset of the functionality you're considering, and one thing I've had (and liked) was the ability to customize how the time for each tweet was displayed.
#2
That's a good idea, I'll definitely make sure the time format can be adjusted. What kind of options do you think would be good for the time format?
#3
While I have specific preferences for my personal use, it seems like there's a better option: letting the user decide. I can think of two ways to do this:
1) making the output a themable function, so the user can customize the output or
2) providing a form field on the settings (?) page for this module allowing the user to put in a PHP formatting string, like "h:i a"?
Almost every culture has a slightly different convention on how to write out times, and either of those options will let the user decide.
#4
Hrm. I'm not yet very up on integrating themeing, but #2 sounds like a good idea. I'm thinking something along the lines of some "standard" types with a "custom" field that you can make use of. Something that shows something like:
23:59
11:59 pm
Custom
And custom makes a box appear that lets you enter whatever you want. What do you think?
#5
Wait a minute -- when you talk about themeing you aren't talking about me providing some box that's like
%h:%s %m-%y or something like that are you -- you are talking about providing a simple hook into the theming engine so someone writing their own theme can adjust the way daily twitter's output looks
am i correct?
#6
(and if i have your attention, do you know how to revoke a release? i can't figure out how)
#7
Yep, I'm looking for a function the end user can override.
Don't know how to revoke a release, though...
#8
Oh oh, so you -are- looking for end user, not the person who is able to edit the actual theme. Ok, let me think about that. I'm a little lukewarm on making it something as free form as %s %m:%s %y:%M:%d but maybe that's not as bad as I'm thinking it would be. Do you ahve any thoughts on how this customization functionality should look to the end user?
#9
For customizing time format, I suggest we just support /admin/settings/date-time/formats.
In Drupal 7 we could implement hook_date_format_types() to add our own format then call format_date with it. In D6 we could just check variable_get for date_format_time (I made that up) or date_format_dailytwitter set to "h:i a" as default. Users can define a date-time format which would be used if found.