Hi,

Having problem with transformation of URLs in "hand coded" HTML links :

href="project/thing" > href="drupal/project/thing#"

where my site is running at http://localhost/drupal.

On selecting the processed link it correctly goes to target 'drupal/project/thing' and then jumps to bottom of page because of trailing '#' with no anchor.

Glad for advice and thanks for developing Pathologic,

Webel

CommentFileSizeAuthor
#4 pathologic.module.zip2.89 KBGarrett Albright

Comments

webel’s picture

webel commented

Amendment:

href="project/thing" > href="/drupal/project/thing#"

BTW I tested switching Pathologic input filter on and off and isolated other input filters, too.

jjalocha’s picture

jjalocha commented

I tested this with Firefox 3.0 and Opera 9.27, and it doesn't jump to the bottom of the page, here. So it's probably a browser specific behaviour.

But I still agree, it looks weird, and I would be glad if we could get rid of this unnecessary element.

Garrett Albright’s picture

Garrett Albright commented

I'll try to look into this on the weekend (and I really mean it this time… maybe).

Garrett Albright’s picture

Garrett Albright commented
StatusFileSize
new pathologic.module.zip2.89 KB

Okay, I got a chance to look at this tonight. And yeah, it's broken.

Le sigh… It seems like every time I think I've got this right, it turns out I've just broken something else and not noticed it yet. And truth be told, I don't really use this module much myself, so I'm rarely the first one to notice it.

webel and jjalocha, could you try replacing pathologic.module with the attached file and letting me know if it fixes things? (You'll have to edit your nodes and/or dump your cache before Drupal will re-run input filters on your content again.)

webel’s picture

webel commented

Hi,

The patch doesn't seem to work at all.

I downloaded and installed the pathalogic.module.

Afterwards EVERY page opened as a single line of text:

project/drancing/software

(which is just one alias I am using, Drancing is one of my R&D projects).
The page source showed no HTML, just that line of text, and always the same.

I tried a diff of the old .module and the patch .module, however could not see why.

I replaced the patch with the original and it worked again (but of course still with the # problem).

FYI am using Firefox 3.05 and Safari 3.1.2 on Mac OS X 10.5.4.

jjalocha’s picture

jjalocha commented

Exactly the same problem here. Wherever try to navigate, I only get a text-page with one pathname '../top-one', 'top-one' being my main page.

The leading '../' is probably related to multi language setup here. I am using language prefixes for all languages.

Garrett Albright’s picture

Garrett Albright commented

Argh, I'm so dumb. I forgot to delete a testing line. Please try deleting line 164, which looks like:

		die(drupal_get_path_alias($path));

and try again.

jjalocha’s picture

jjalocha commented

Thanks, that fixes it! I tested it in a multilanguage set-up, with the following pages:
* top-page (default prefix empty)
* top-page/sub-page
* en/top-page (default prefix en)
* en/top-page/sub-page
As expected, it doesn't work correctly with translated pages:
* de/top-page
* de/top-page/sub-page
But it doesn't break anything. It just directs all links to the default language, which is the same behavior we had before applying the patch.

Thank you, Garrett, for the help!

Jerzy

webel’s picture

webel commented

Yes, that seems to have fixed it, one less worry, thanks for your prompt attention, Webel

Garrett Albright’s picture

Garrett Albright commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.