First of all I must say this is a lovely, simple to use module. Very pleased.

I'm just having one problem.. I need to video to constantly be at a 390px width, which I have set in the filter settings. However, the video's being pumped out seem to only honour the height set and the width is then the correct ratio for the height, which is too wide.

Is there a way to make the width be the value that is set in stone and the height adjusts accordingly? Perhaps a value of 0 for the height?

Thanks very much.

CommentFileSizeAuthor
#11 346855-video_filter-priority_setting-1.patch2.07 KBmrfelton
#4 346855-priority_setting.patch2.51 KBblackdog

Comments

mrfelton’s picture

mrfelton commented

problem for me too.

mrfelton’s picture

mrfelton commented
Title: Default height overrides default width? » Height overrides width?
Version: 6.x-2.4 » 6.x-2.5

Actually, this happens for the height and width defined on the tag too, not just the defaults. (changing title to reflect this)

jabberwok’s picture

jabberwok commented

me too

I fixed it by going into the video_filters.inc file and changing the default ratio to what I wanted then set the height in settings.

My problem is when I set the height/width it appears that size in both teasers and node views

blackdog’s picture

blackdog commented
Assigned: Unassigned » blackdog
Status: Active » Needs review
StatusFileSize
new 346855-priority_setting.patch2.51 KB

Yes, this is how the module was designed, but I can see how it's (more) useful to be able to have the height adjust to the width, not the other way around.

It's really a simple change, but I'm hesitant to just change it. I've made it a setting which defaults to height taking priority since that's what we have today. Please test!

mrfelton’s picture

mrfelton commented
Status: Needs review » Reviewed & tested by the community

Does the trick. Thanks.

blackdog’s picture

blackdog commented
Status: Reviewed & tested by the community » Fixed

Committed both branches.

jumpfightgo’s picture

jumpfightgo commented

Works great for me to. thx

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thanks for the patch. I'm looking forward to the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mrfelton’s picture

mrfelton commented
Version: 6.x-2.5 » 6.x-2.x-dev
Status: Closed (fixed) » Active

This doesn't seem to be in the latest DRUPAL-6--2 branch??

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 346855-video_filter-priority_setting-1.patch2.07 KB

Updated patch to work with latest CVS.

blackdog’s picture

blackdog commented
Status: Needs review » Closed (works as designed)

We removed this option in favor of a new way of calculating size, see #644130: Unexpected or even wrong scaling of videos. I haven't yet released that code though, so if you find that it doesn't work as expected, let me know.