Height overrides width?
domhay - December 14, 2008 - 13:04
| Project: | Video Filter |
| Version: | 6.x-2.5 |
| Component: | Miscellaneous |
| Category: | support request |
| Priority: | normal |
| Assigned: | blackdog |
| Status: | closed |
Description
First of all I must say this is a lovely, simple to use module. Very pleased.
I'm just having one problem.. I need to video to constantly be at a 390px width, which I have set in the filter settings. However, the video's being pumped out seem to only honour the height set and the width is then the correct ratio for the height, which is too wide.
Is there a way to make the width be the value that is set in stone and the height adjusts accordingly? Perhaps a value of 0 for the height?
Thanks very much.
#1
problem for me too.
#2
Actually, this happens for the height and width defined on the tag too, not just the defaults. (changing title to reflect this)
#3
me too
I fixed it by going into the video_filters.inc file and changing the default ratio to what I wanted then set the height in settings.
My problem is when I set the height/width it appears that size in both teasers and node views
#4
Yes, this is how the module was designed, but I can see how it's (more) useful to be able to have the height adjust to the width, not the other way around.
It's really a simple change, but I'm hesitant to just change it. I've made it a setting which defaults to height taking priority since that's what we have today. Please test!
#5
Does the trick. Thanks.
#6
Committed both branches.
#7
Works great for me to. thx
#8
Thanks for the patch. I'm looking forward to the next official release.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.