I was reviewing the changes in Drupal 6.8 and noticed what I think is a missing return statement.
I don't know what potential bugs it couses, but I decided to create a patch for it anyway. This is my first ever Drupal patch so please be nice...

CommentFileSizeAuthor
#5 locale.inc_.patch372 byteskajetan
#3 locale.inc_.patch374 byteskajetan
locale.inc_.patch374 byteskajetan

Comments

damien tournoud’s picture

damien tournoud commented
Version: 6.8 » 7.x-dev
Status: Needs review » Reviewed & tested by the community

Bumping to D7, which has exactly the same code. The only consequence of that bug is that the user is redirected to admin/build/translate instead of admin/build/translate/import.

The patch itself applies to D7 and looks good. I'm not convinced this requires testing, so RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

kajetan’s picture

kajetan commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new locale.inc_.patch374 bytes

Ok, thanx. I changed the status and upload another patch, that was made against 7.x-dev. Hope it will work.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

kajetan’s picture

kajetan commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new locale.inc_.patch372 bytes

That didn't work... So how about this? (there seems to be no good tools to create patches on windows)

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD. Moving to D6. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6 as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.