Download & Extend

Missing return statement in locale.inc

Project:Drupal core
Version:6.x-dev
Component:locale.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I was reviewing the changes in Drupal 6.8 and noticed what I think is a missing return statement.
I don't know what potential bugs it couses, but I decided to create a patch for it anyway. This is my first ever Drupal patch so please be nice...

AttachmentSizeStatusTest resultOperations
locale.inc_.patch374 bytesIdleFailed: Failed to apply patch.View details

Comments

#1

Version:6.8» 7.x-dev
Status:needs review» reviewed & tested by the community

Bumping to D7, which has exactly the same code. The only consequence of that bug is that the user is redirected to admin/build/translate instead of admin/build/translate/import.

The patch itself applies to D7 and looks good. I'm not convinced this requires testing, so RTBC.

#2

Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#3

Status:needs work» reviewed & tested by the community

Ok, thanx. I changed the status and upload another patch, that was made against 7.x-dev. Hope it will work.

AttachmentSizeStatusTest resultOperations
locale.inc_.patch374 bytesIdleFailed: Failed to apply patch.View details

#4

Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#5

Status:needs work» reviewed & tested by the community

That didn't work... So how about this? (there seems to be no good tools to create patches on windows)

AttachmentSizeStatusTest resultOperations
locale.inc_.patch372 bytesIdlePassed: 7641 passes, 0 fails, 0 exceptionsView details

#6

Version:7.x-dev» 6.x-dev

Committed to CVS HEAD. Moving to D6. Thanks!

#7

Status:reviewed & tested by the community» fixed

Committed to Drupal 6 as well.

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here