Missing return statement in locale.inc
kajetan - December 15, 2008 - 13:19
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | locale.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
I was reviewing the changes in Drupal 6.8 and noticed what I think is a missing return statement.
I don't know what potential bugs it couses, but I decided to create a patch for it anyway. This is my first ever Drupal patch so please be nice...
| Attachment | Size |
|---|---|
| locale.inc_.patch | 374 bytes |
| Testbed results | ||
|---|---|---|
| locale.inc_.patch | failed | Failed: Failed to apply patch. Detailed results |
#1
Bumping to D7, which has exactly the same code. The only consequence of that bug is that the user is redirected to admin/build/translate instead of admin/build/translate/import.
The patch itself applies to D7 and looks good. I'm not convinced this requires testing, so RTBC.
#2
The last submitted patch failed testing.
#3
Ok, thanx. I changed the status and upload another patch, that was made against 7.x-dev. Hope it will work.
#4
The last submitted patch failed testing.
#5
That didn't work... So how about this? (there seems to be no good tools to create patches on windows)
#6
Committed to CVS HEAD. Moving to D6. Thanks!
#7
Committed to Drupal 6 as well.
#8
Automatically closed -- issue fixed for two weeks with no activity.