When construction links to individual taxonomy pages the function taxonomy_term_path() should really be used instead of hard coding the path to 'taxonomy/term/{tid}'. This would make a useful module even better since it allows other modules to control what page is actually shown. Useful when using taxonomy redirect and views.

I filed this as a bug since the call to taxonomy_term_path() is the proper way to get the path.

Comments

AlexisWilke’s picture

AlexisWilke commented

nevets,

Okay, I fixed that in two places in the 6.x-1.0-dev.

Now... What about this one?

'taxonomy/term/'. $term->tid .'/all'

And should the taxonomy_vtn/term/{tid} be using such a system?
(in other words, call module_invoke($vocabulary->module, 'vtn_term_path', $term) or something like that)

Thank you.
Alexis Wilke

nevets’s picture

nevets commented

For 'taxonomy/term/'. $term->tid .'/all' I would use taxonomy_term_path($term) .'/all'.

I do not see a reason for your module to implement such a hook, the value with the taxonomy module it provdes a way to override how nodes associated with a term are displayed. In your case you are providing a way to navigate to those term pages, if someone wants a different form of navigation they can implement a new module.

AlexisWilke’s picture

AlexisWilke commented
Version: 6.x-1.0-rc6 » 6.x-1.x-dev
Assigned: Unassigned » AlexisWilke
Status: Active » Fixed

This is done in CVS. You should have a new -dev to test with within the next 12 hours.

Watch out, if you were using -rc6, then you will be affected by some of my other changes to support more features and fixes to the existing code...

Thank you.
Alexis

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.