Misplaced functionality on group node delete
| Project: | Organic Groups Blueprints |
| Version: | 5.x-1.0-alpha6 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Fresh install of:
Drupal 5.12
OG 5.x-7.3
OG Blueprints 5.x-1.0-alpha6
Panels 5.x-2.0-rc1a
Views 5.x-1.6
OG Blueprints Operating Mode: One Bundle Per Group Type
Group node types: 'Page'
I created a blueprint to use as the home page for the 'Page' content type. I set up the blueprint the way I wanted, created a release, then created a 'page' group. All went well. However, when deleting the group, my blueprint for the 'page' content type got destroyed (or corrupted or something). I repeated the process above as both drupal admin (and tried both options on delete) and as non-drupal group admin, but all 3 ended in the same result. Looking closer at the options, it appears to me like these options should be displayed when a content type is deleted, not when a node is deleted.
| Attachment | Size |
|---|---|
| Result-Blueprint.png | 240.09 KB |
| Result-Bundle.png | 226.75 KB |
| Group-delete2.png | 204.98 KB |
#1
After further review, this functionality is indeed misplaced. A patch is attached that moves this functionality from node deletion to content type deletion. This fixes the error messages and properly deletes the bundle and blueprint associated with the content type.
#2
Whoops. That looks like a totally brainless thing I did right there :)
Sorry I didn't see this when you first posted it. I'll try to get to checking this tonight...
#3
sdboyer hi,
Wondering if you were able to confirm that
1) this patch correctly fixes the error
2) doesn't break anything else thats obvious in function or more important ... prior data ...
3) were you able to actually test it or know if anyone has?
thanks
#4
Sorry for the delay. The code looks right, and passed my quick test, so committing it. Thanks!
#5
Automatically closed -- issue fixed for 2 weeks with no activity.