The final link/img tag output should be themeable for maximum flexibility. The attached patch moves the img tag output to a theme function, and adds the required implementation of hook_theme.

The use case for this is if a given theme wants to use, for example, a text link instead of an image, it can do so without the developer having to hack on the addthis module.

CommentFileSizeAuthor
#1 addthis.theme_.patch843 bytesjhedstrom
addthis.theme_.patch881 bytesjhedstrom

Comments

jhedstrom’s picture

StatusFileSize
new843 bytes

Here's a working patch. The patch above moved the theme function to addthis.theme.inc, but I figured I'd keep it simple and leave the function in the module file.

vesapalmu’s picture

Status: Needs review » Fixed

I just committed this patch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.