Fresh install of:
Organic Groups 5.x-7.3
Views 5.x-1.6
OG Forum 5.x-2.2

Here is the problem: After enabling OG Forum, I simply disable it and then uninstall it. Pretty simple. Upon uninstalling, I get the error "There was an error removing the OG Forum database tables or variables." I look at the database and see the tables have been removed, just like they should be. Then, when I look at the uninstall code in og_forum.install, I see this conditional:

if(variable_del('forum_default_name') && variable_del('forum_default_container_yn') && variable_del('forum_default_container') && variable_del('forum_allow_public')
  && variable_del('forum_all_public') && variable_del('forum_auto_public') && variable_del('forum_limit'))

After consulting my bible (the drupal api), I noticed that the function variable_del does not return a value. This means that the first statement in the conditional is run (variable_del('forum_default_name')), does not return a boolean TRUE, and the conditional fails. The $vardel variable is not set to TRUE which ultimately triggers the error message explained above. This also means that only the first of the 7 variables is actually deleted.

CommentFileSizeAuthor
#1 og_forum-347795-1.patch1.07 KBpathfinderelite

Comments

pathfinderelite’s picture

Status: Active » Needs review
StatusFileSize
new1.07 KB

here is a patch that properly deletes the variables

Anonymous’s picture

Would you please upgrade to D6 if you would like me to give you support with this module , thanks

pathfinderelite’s picture

Unfortunately I am stuck with drupal 5 at the moment... Is this module not longer supported for drupal 5?

Anonymous’s picture

Thanks for fixing this problem and providing a patch . If one other person can independently confirm this patch as reviewed. I'll get your work committed to the development branch.

Since late December my focus is to have this module released officially as a 6.x-1.0 so i will no longer personally be looking at reported problems on D5 or back porting any further modifications to D6 back to D5. I just don't have the time to do this unfortunately.

Best, Paul

Anonymous’s picture

Assigned: Unassigned »

I seem to recall fixing this. Would you please reopen if that is not the case.

Thanks Paul

pathfinderelite’s picture

Status: Needs review » Fixed

Looks fixed in the latest 5.x and 6.x versions. The variable_del function calls are being called properly. Good work.

dugh’s picture

I still see an error when uninstalling og_forum.

og_forum or og or forum also has a problem in that not forum topic posts are showing up in a forum.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.