This patch enables autosubscribe module to check if the node's content type is on the allowed content types list (admin/messaging/notifications/content) before adding the subscription. In the current release, when a user edits his/her usernode, that results with a subscription to his/her own usernode under thread subscriptions. This patch prevents this by adding an extra check.

CommentFileSizeAuthor
#11 notifications_autosubscribe-type-enabled.patch1.05 KBdsnopek
#7 notifications_autosubscribe-check-type-before-auto-sub.zip3.09 KBMercury500
notifications_autosubscribe6.x-1.0ContentTypeFix.patch1015 bytesmehmeta

Comments

a_c_m’s picture

a_c_m commented

This looks like a good patch to me, works for me.

fred0’s picture

fred0 commented

I haven't had a chance to test this, but it is certainly functionality I would like to see added.

lolmaus’s picture

lolmaus commented

Subscribing

sherryheinz’s picture

sherryheinz commented

subscribe

brisath’s picture

brisath commented

I would like to have this feature also.

a_c_m’s picture

a_c_m commented

@lolmaus, @sherryheinz, @brisath

Please test the patch, if it works for you as well, set the status to "reviewed and tested by the community" and then this patch will be very likely be committed.

[vent]
Adding "subscribe" or "i want this feature too" to a feature request with a patch thats already been confirmed to work by one member of the community doesn't help get it implemented.
[/vent]

If you dont know how to apply a patch, its not as hard as you might think, there are detailed instructions here http://drupal.org/node/60108

Testing patches for module creators is a great way to help give back to the Drupal community AND get the features you want (that someone else has take the time and effort to write) implemented into your favourite modules!

Mercury500’s picture

Mercury500 commented
StatusFileSize
new notifications_autosubscribe-check-type-before-auto-sub.zip3.09 KB

This was VERY useful. Used on Drupal 6.19, Notifications version = "6.x-2.2"

I manually inserted it into the notifications\notifications_autosubscribe\notifications_autosubscribe.module file (// $Id: notifications_autosubscribe.module,v 1.2.2.3.2.5.2.1 2009/04/19 11:02:20 jareyero Exp $A) and it seems to be working fine.

I had a great need of this type of control. I had an organic group where one content type had hundreds of daily submissions of a supplementary nature to another content type. There was no need to autosubscribe to that content type's threads, yet there were hundreds of 'thread' subscriptions being generated.

I hate most patches - to many steps for a simple file switch. I've included the files if anybody else would like them - ready to go/test. (they need to be renamed before using - removing '.patched' or '.orig')

I would greatly like to see this functionality included in Notifications.

Thanks.

a_c_m’s picture

a_c_m commented
Status: Needs review » Reviewed & tested by the community

2 people saying it works, sounds like "reviewed and & tested to me"

brisath’s picture

brisath commented

I'll looking forward to seeing this implemented.

Slovak’s picture

Slovak commented

The patch worked for me as well.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Version: 6.x-1.x-dev » 6.x-4.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new notifications_autosubscribe-type-enabled.patch1.05 KB

I've created a patch that accomplishes the same thing, but for notifications-6.x-4.x dev. Please review!

Regards,
David.