Really interested to this module. But cant have it yet due to incompatibility issue.

Can you guys try and check it out on D6.8 installation?

Regards

Comments

fang27’s picture

I'm interested too. Doesn't work with 6.8 yet. What would it take to get it working?

Thank you! This has been a great module with D5x.

Fintan Darragh’s picture

Status: Active » Needs work
StatusFileSize
new614 bytes

Hi guys,

I've had a go at getting the uc_donation module (but not the uc_donate module) working with Drupal 6.8.

I've managed to fix a bug which was causing an error like this one:

warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'uc_product_add_to_cart_form_1' was given in [drupal path]/includes/form.inc on line 366.

...which was preventing users from adding the donation to their cart.

The problem was that the theme_uc_product_add_to_cart function in the uc_product module was calling a function which doesn't exist.

The attached patch seems to fix this issue (for Ubercart 6.x-2.0-beta1), but it's not exactly what I'd call a fix!

It does appear to work, though. I'm not sure what functionality will suffer as a result of this, but I haven't seen anything obvious yet. So... use with caution :D

Cheers,
-Fin

Fintan Darragh’s picture

StatusFileSize
new938 bytes

Hey,

Erm actually that patch isn't as good as this one, which is a patch of uc_donate.module (thereby not affecting other product types).

-Fin

solotandem’s picture

Status: Needs work » Needs review
StatusFileSize
new20.1 KB

I am also interested in using this module with D6 and have attached a patch that does the following:

1) cleans up uc_donation.module for remaining (?) D5 to D6 changes.
2) cleans up uc_donate.module, uc_donate.install, and uc_donate.info for D5 to D6 changes.

I have not tested the uc_donate code but have done some testing with the uc_donation code.

One problem I found was the quantity always equal to 2 when you add a donation to cart once. This was caused by two submit handlers calling uc_cart_add_item. The uc_donation module does the same as uc_product so the submit handler is unnecessary at this time.

The uc_donate module has an enum data type which is not supported by schema api. I changed it to varchar. Please address this.

Try out the patch and see if it works.

solotandem’s picture

StatusFileSize
new19.94 KB

Cleaned up the patch file from my previous post.

ransomweaver’s picture

I put uc_donation.patch in the uc_donation dir and run

patch -p0 < uc_donation.patch

and I get

patching file uc_donate/uc_donate.install
patching file uc_donate/uc_donate.info
patch: **** malformed patch at line 116: Index: uc_donate/uc_donate.module

my donation module is
$Id: uc_donation.info,v 1.1.4.1 2008/11/13 22:23:41 greenskin Exp $

ahkiam’s picture

Status: Needs review » Needs work

I applied solotandems 1/3/09 patch and am able to successfully create donation products and add them to cart from the product page. However, I'm now getting the following error on every page:

warning: Invalid argument supplied for foreach() in MYSITE\sites\all\modules\uc_donation\uc_donation.module on line 534.

Also, the Donate page is ignoring the Title field and not displaying any donation products that have been attached.

ahkiam’s picture

workaround: I disabled the attribute module, which is what the foreach() is dealing with, since I'm not actually using it. Now I don't have to look at the constant error reports. So your patch looks like it's good for everything but uc_attribute.

ransomweaver’s picture

You didn't get the "patch: **** malformed patch at line 116" error when you patched? I didn't try using after the failed patch.
I assumed since it didn't say "patching uc_donate.module" and "patching uc_donation.module" that it didn't do any more patching after the error.

ahkiam’s picture

I manually patched it -- thought it might help me understand what's going on.

greenskin’s picture

A patch has been submitted in #8 at #341819: Allow contrib modules to utilize uc_product_add_to_cart_form that allows donation products to be successfully added to the cart in Drupal 6 and Ubercart 2.

The Ubercart developers haven't been replying to that issue as of late so any help there in getting their attention to commit the patch would benefit uc_donation greatly and any other module which creates their own product type.

fang27’s picture

I replied on the other thread, and would just like to point out here as well, that the patch mentioned does allow a donation product to be added to the cart, but it cannot be removed or adjusted while in the cart.

greenskin’s picture

The latest dev release has fixed the issue of the donation product not being able to be removed or adjusted as long as the suggest patch in #11 is applied.

fang27’s picture

Applied the patch, installed the newest dev release this morning - seems to have changed nothing..... :\

fang27’s picture

Ok, so after poking around, it seems that it isn't the DEV release one wants - it is this:

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/uc_donation...

With that update (replacing the module file with either Revision 1.2.4.9 or Revision 1.2.4.10) - it does remove items from the cart and update donation items in the cart.

Great job, thanks!

domesticat’s picture

I've tested the dev version released February 9 and while it fixes most of the problems, it misses one.

On the individual product pages, the Add To Cart button works.
On the category pages (listing multiple products) the Add To Cart button isn't appearing.

bunger’s picture

Does anyone know the status of this issue? I am running the 2/10/09 dev release and am also receiving the following error:

warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'uc_catalog_buy_it_now_form_8' was given in /demo/includes/form.inc on line 358.

I have tried the most recent patches previously posted and also get the "malformed patch..." error. I would really like to get the donation module going, but this is a show stopper...

greenskin’s picture

Status: Needs work » Fixed

Today's dev release should result in donation products correctly being added to cart from the catalog pages and this dev release should result in a Drupal 6, Ubercart 2.0 fully compatible release. After more testing and bug squashing we soon will have an official stable release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.