this patch makes a change to _uc_reports_timezone_offset(), using the user's timezone if possible before falling back on the sitewide default. This behavior was observed in format_date().

CommentFileSizeAuthor
#7 uc_reports.timezone.help_.patch5.2 KBcha0s
uc_reports.timezone.2.patch728 bytescha0s

Comments

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

Hooray for doing things as the user expects.

rszrama’s picture

rszrama commented
Status: Fixed » Needs review

I know this has already been committed and all, but I'm wondering if it's really a good thing for reports to differ based on the user's timezone. In terms of sales and when things go through, it makes sense to me that you'd want to have a single timezone for reporting... particularly the store's own timezone (which I'd assume is the site's timezone). Wish I had chimed in sooner, but are there any other thoughts here? In terms of financial reporting, it's just not really something that should be variable. Might have to get some input from someone actually running a business here.

cha0s’s picture

cha0s commented

You raise a good point... I'm totally cool if you wanna revert it, it's not that big of a change at all. :)

Maybe we should just display on the reports "All reports are [timezone offset] GMT" or something. That should eliminate confusion while keeping things consistent.

rszrama’s picture

rszrama commented
Status: Needs review » Needs work

Oh! I like that idea. :)

I image you can just use the timezone text that Drupal uses for the timezone selection form.

Island Usurper’s picture

Island Usurper commented

Reverted the patch since it kept #344890: Timezone causes off-by-one error in reports (use Drupal time instead of server's) from being taken care of easily.

cha0s’s picture

cha0s commented
Assigned: Unassigned » cha0s
cha0s’s picture

cha0s commented
StatusFileSize
new uc_reports.timezone.help_.patch5.2 KB

Here's a patch for the timezone offset display on sales reports. Also, I went ahead and optimized reports' hook_help logic a bit.

Island Usurper’s picture

Island Usurper commented
Status: Needs work » Fixed

You forgot the break; statements. :)

Fixed and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.