If I click on "Administer My Categories" and then on "List terms", the terms are displayed correctly but the title is "Terms for !vocab".

So there is "!vocab" instead of the vocabulary name.

CommentFileSizeAuthor
#3 taxonomy_delegate_348646_badtitle.patch718 bytesdboulet

Comments

leszek.hanusz’s picture

leszek.hanusz commented

I found the problem, the line 373 of taxonomy_delegate.module should be:
drupal_set_title(t('Terms for %vocab', array('%vocab' => check_plain($vocabulary->name))));

dboulet’s picture

dboulet commented
Title: Bad title in the listing of terms in "Administer My Categories" » Bad use of t() in title of terms overview pages

When using the %variable placeholder, the replacement string is automatically sent through check_plain(), so the line could simply be:

drupal_set_title(t('Terms for %vocab', array('%vocab' => $vocabulary->name)));
dboulet’s picture

dboulet commented
Category: bug » task
Status: Active » Needs review
StatusFileSize
new taxonomy_delegate_348646_badtitle.patch718 bytes

Finally got around to creating a patch for this.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs review » Fixed

Oops, I had already noticed it and fixed it. Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.