I just installed it for testing purposes, and ran coder (6.x-1.0) with settings "Converting 5.x modules to 6.x" and "Drupal Security Checks" on. Here are the results:

  • Line 35: Menu item titles and descriptions should now no longer be wrapped in t() calls. (Drupal Docs)
    'description' => t('AJAXifies comments on site.'),
  • Line 174: hook_form_alter() parameters have changed (Drupal Docs)
    captcha_form_alter($form_c, NULL, 'comment_form');

Coder shows both as critical, although I'm not sure they are, not a pro-developer myself.

The second one might be something of interest to issue #349035

Hope this helps :)

Comments

neochief’s picture

neochief commented
Status: Active » Fixed

Thanks, for your help Manuel. I can confirm the first bug and fixed it already in HEAD. As for the second, I have no idea why coder marks it as error at all. All params are passing correct there. Anyway, thank you for report. Hope module will work well for you :)

manuel garcia’s picture

manuel garcia commented

Hummm ok, I took a look at the link that coder points to for the second bug, looks like the first parameter is passed as reference:

function my_module_form_alter(&$form, $form_state, $form_id) {
  if ($form_id == 'my_form') {
    // Form modification code goes here; $form_state cannot be modified,
    // but decisions can be made based on its contents.
  }
}

So perhaps Line 174 should be like this?
captcha_form_alter(&$form_c, NULL, 'comment_form');

I could be waaay off here, so disregard my comment if its the case :S

Anyway, glad to be of help, this module should probably get a lot of attention, since it improves useability and enhances the user experience on any site.

neochief’s picture

neochief commented

No, no, &$form is incorrect :) Reference is should be shown only in function declaration, not in actual calls. Bug will occur if you'll try to call something like
captcha_form_alter(array('a' => 'b'), NULL, 'comment_form');
because array('a' => 'b') is not variable. But in our case, everything is right.

manuel garcia’s picture

manuel garcia commented

ah heh, so way off ... lol nevermind

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.