JavaScript on every page [#349319]

Having:

  drupal_add_js(drupal_get_path('module', 'filefield') .'/filefield.js');

... in hook_init will stick the filefield JavaScript on every page, no matter if it's required or not. Would be nice to only add it when it's needed.

Comment	File	Size	Author
#3	349319.patch	1.27 KB	robloach

Comments

Comment #1

Flying Drupalist commented 20 December 2008 at 22:44

But if you use javascript aggregation then it shouldn't matter. Having them separately requires you to load a different aggregated js for different pages, which would nullify any gains from loading separately.

Comment #2

robloach

he/him

commented 20 December 2008 at 23:16

One of my sites, I don't use JavaScript at all. So the page is being rendered with jQuery, FileField and Drupal.settings.basePath, and isn't even using them. Would be nice to only include it when it's required. I'll have a look at this on Monday.