If i activate the OpenID-Module and the Remember Me Module the OpenID-Form is empty - the OpenID-field is missing...

CommentFileSizeAuthor
#4 login_submit-openid-5.x-1.2.patch2.03 KBnickl
#3 Picture 6.png18.14 KBnickl

Comments

nickl’s picture

nickl commented

Assuming OpenID module refers to: http://drupal.org/project/openid

Will look into this issue...

daphisto’s picture

daphisto commented

Just wondering if there was any movement on this?

nickl’s picture

nickl commented
Title: Doesn't work with OpenID enabled » OpenID - User forgotten after openid auth
StatusFileSize
new Picture 6.png18.14 KB

Testing with openid.
Field displays and authentication works, see attachment for screenshot of login form.
D6 works as expected.
D5 user is not remembered after closing browser when authenticated via openid.

Will look into this when I get a moment...

nickl’s picture

nickl commented
Title: OpenID - User forgotten after openid auth » Discarded login form values
Project: Remember me » OpenID
Version: 5.x-2.0-alpha1 » 5.x-1.2
Component: Code » OpenID Client
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new login_submit-openid-5.x-1.2.patch2.03 KB

The problem lies with openid module discarding the form_values which the D6 version does not do.

When OpenID authentication succeeded and user already exists user_login_submit gets called, which in turns processes hook_user op = login, with empty form_values. The D6 core version of openid stores the submitted form_values in $_SESSION['openid']['user_login_values'], before redirecting to the OpenID provider, which gets passed on to the login chain again after authentication. The attached patch duplicates this functionality, rolled against version 5.x-1.2.

Assigning issue to openid project, please apply patch and provide a new version for D5.x users to download.

nickl’s picture

nickl commented

Has anyone had a look at this yet?
It's a straight forward patch an mimics the behaviour of the 6.x version so I expect no debates to follow. If there is anything I can do to be of assistance, please shout.